Update dropshot and rust toolchain #947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the toolchain update has somehow broken how phd-runner locates its testcases via the |
|
rust 1.89 and later result in broken |
|
Thoughts on not using the inventory crate? That might be an easier fix. The context is that opte has moved to Rust 1.90 (cc @rcgoodfellow) and the opte version here can't be bumped until this is resolved or the opte change is reverted. @jclulow is also looking at fixing the upstream rustc bug. |
|
Was opte bumped for a specific reason, or "just because"? |
|
Closed in favor of #952 |
sunshowers
added a commit
that referenced
this pull request
Sep 26, 2025
Followup to #947. While the inventory crate is busted on illumos with Rust 1.89 and above, it appears (based on my local testing) that the linkme crate works okay. Also migrate `rust-toolchain.toml` to 1.90, bump Dropshot, and fix clippy warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dropshot update gets us past the clippy nits previously emitted by rust 1.89. The rest for 1.90 are address in the follow-up.