Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML email not rendering correctly #2120

Closed
ashokm opened this issue Dec 5, 2022 · 5 comments · Fixed by #2158
Closed

HTML email not rendering correctly #2120

ashokm opened this issue Dec 5, 2022 · 5 comments · Fixed by #2158
Labels
bug Something isn't working

Comments

@ashokm
Copy link
Contributor

ashokm commented Dec 5, 2022

When using the Azure Comment Reporter to receive Pull Request and Email notifications, the Pull Request comments are being shown correctly, but the Email does not render the bold text or image correctly.


Pull Request:
image

Email:
image


Version:

 - Image Creation Date: 2022-11-23T22:14:25Z
 - Image Revision: d8612e7
 - Image Version: v6
@ashokm ashokm added the bug Something isn't working label Dec 5, 2022
@nvuillam
Copy link
Member

@ashokm maybe Azure emails does not allow to display images externally stored ?

markdown is the following and seems correct:

_MegaLinter is graciously provided by [![OX Security](https://www.ox.security/wp-content/uploads/2022/06/logo.svg?ref=megalinter_comment)](https://www.ox.security/?ref=megalinter)_

@ashokm
Copy link
Contributor Author

ashokm commented Dec 21, 2022

It's not just the image that is the issue. You can also see asterisks being shown instead of the bold text:
image

nvuillam added a commit that referenced this issue Dec 21, 2022
Fixes #2120
 Set `REPORTERS_MARKDOWN_TYPE` to `simple` to avoid external images in PR/MR markdown comments.
@nvuillam
Copy link
Member

Got it, it seems markdown to email routine of Azure does not like some elements of Github Flavored Markdown

PR on its way, I simplified it, and added an option REPORTERS_MARKDOWN_TYPE, to set to simple to avoid external images in PR/MR markdown comments.

nvuillam added a commit that referenced this issue Dec 21, 2022
Fixes #2120
 Set `REPORTERS_MARKDOWN_TYPE` to `simple` to avoid external images in PR/MR markdown comments.
@nvuillam
Copy link
Member

@ashokm you can now test with MegaLinter beta + REPORTERS_MARKDOWN_TYPE: simple

@ashokm
Copy link
Contributor Author

ashokm commented Dec 22, 2022

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants