Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML email not rendering correctly #2158

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

nvuillam
Copy link
Member

Fixes #2120
Set REPORTERS_MARKDOWN_TYPE to simple to avoid external images in PR/MR markdown comments.

Fixes #2120
 Set `REPORTERS_MARKDOWN_TYPE` to `simple` to avoid external images in PR/MR markdown comments.
@nvuillam
Copy link
Member Author

nvuillam commented Dec 21, 2022

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.01s
✅ BASH shellcheck 7 0 0.37s
✅ BASH shfmt 7 0 0 0.33s
✅ COPYPASTE jscpd yes no 2.3s
✅ DOCKERFILE hadolint 105 0 9.92s
✅ JSON eslint-plugin-jsonc 21 0 0 1.92s
✅ JSON jsonlint 19 0 0.21s
✅ JSON v8r 21 0 14.2s
⚠️ MARKDOWN markdownlint 297 0 11 5.18s
✅ MARKDOWN markdown-link-check 297 0 4.58s
✅ MARKDOWN markdown-table-formatter 297 0 0 14.19s
✅ OPENAPI spectral 1 0 0.7s
⚠️ PYTHON bandit 171 43 2.28s
✅ PYTHON black 171 0 0 4.06s
✅ PYTHON flake8 171 0 1.91s
✅ PYTHON isort 171 0 0 0.7s
✅ PYTHON mypy 171 0 6.56s
✅ PYTHON pylint 171 0 10.52s
⚠️ PYTHON pyright 171 274 16.53s
✅ REPOSITORY checkov yes no 25.67s
✅ REPOSITORY git_diff yes no 0.35s
✅ REPOSITORY secretlint yes no 5.81s
✅ REPOSITORY trivy yes no 24.69s
✅ SPELL cspell 712 0 17.01s
✅ SPELL misspell 536 0 0 0.78s
✅ XML xmllint 3 0 0.0s
✅ YAML prettier 80 0 0 2.71s
✅ YAML v8r 22 0 42.46s
✅ YAML yamllint 81 0 1.47s

See errors details in artifact MegaLinter reports on CI Job page

MegaLinter is graciously provided by OX Security

@nvuillam
Copy link
Member Author

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.02s
✅ BASH shellcheck 7 0 0.49s
✅ BASH shfmt 7 0 0 0.04s
✅ COPYPASTE jscpd yes no 2.88s
✅ DOCKERFILE hadolint 105 0 12.1s
✅ JSON eslint-plugin-jsonc 21 0 0 2.18s
✅ JSON jsonlint 19 0 0.24s
✅ JSON v8r 21 0 17.52s
⚠️ MARKDOWN markdownlint 297 2 11 6.26s
✅ MARKDOWN markdown-link-check 297 0 5.58s
✅ MARKDOWN markdown-table-formatter 297 2 0 20.23s
✅ OPENAPI spectral 1 0 0.92s
⚠️ PYTHON bandit 171 43 2.76s
✅ PYTHON black 171 0 0 4.17s
✅ PYTHON flake8 171 0 2.3s
✅ PYTHON isort 171 0 0 0.49s
✅ PYTHON mypy 171 0 8.48s
✅ PYTHON pylint 171 0 13.67s
⚠️ PYTHON pyright 171 272 20.77s
✅ REPOSITORY checkov yes no 31.51s
⚠️ REPOSITORY devskim yes 60 1.26s
✅ REPOSITORY dustilock yes no 1.18s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 4.8s
✅ REPOSITORY syft yes no 3.16s
✅ REPOSITORY trivy yes no 23.06s
✅ SPELL cspell 712 0 21.64s
✅ SPELL misspell 536 2 0 0.51s
✅ XML xmllint 3 0 0.0s
✅ YAML prettier 80 0 0 2.92s
✅ YAML v8r 22 0 51.49s
✅ YAML yamllint 81 0 1.57s

See errors details in artifact MegaLinter reports on CI Job page

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit 5c19ff6 into main Dec 21, 2022
@nvuillam nvuillam deleted the fixes/simplify-md-output branch December 21, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML email not rendering correctly
1 participant