Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

varbit fields in P4-14 are not handled correctly by the translator to P4-16 #481

Closed
mihaibudiu opened this issue Apr 14, 2017 · 2 comments
Closed

varbit fields in P4-14 are not handled correctly by the translator to P4-16 #481

mihaibudiu opened this issue Apr 14, 2017 · 2 comments
Assignees
@mihaibudiu
Labels
bug This behavior is unintended and should be fixed. fixed This topic is considered to be fixed.

Comments

@mihaibudiu
Copy link
Contributor

In particular, headers with varbit fields cannot be extracted using the standard extract method.

At some point there was a proposal for a @length annotation in P4-16, to handle the function of the P4-14 length, but this is not in the current spec. (There are a few P4-16 tests that use the @length annotation, but they also incorrect with the current spec.)
@mihaibudiu mihaibudiu added the bug This behavior is unintended and should be fixed. label Apr 14, 2017
@mihaibudiu
Copy link
Contributor Author

This issue is tightly related to #447.

@mihaibudiu mihaibudiu self-assigned this May 1, 2017
mihaibudiu pushed a commit to mihaibudiu/p4c-clone that referenced this issue May 2, 2017
Fix for issue p4lang#481
45f58e9
@mihaibudiu mihaibudiu added the fixed This topic is considered to be fixed. label May 2, 2017
ChrisDodd pushed a commit that referenced this issue May 4, 2017
@ChrisDodd
Fix for issue #481 (#553)
3a52ba7 
* Fix for issue #481

* Bugfixes

* Improved comments
@mihaibudiu
Copy link
Contributor Author

The translation is still incorrect for header stacks, but we have another issue #576 to keep track of that.

@fefer fefer mentioned this issue Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihaibudiu mihaibudiu

Labels
bug This behavior is unintended and should be fixed. fixed This topic is considered to be fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mihaibudiu