Fix for issue #133 #135
Closed
Fix for issue #133 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 4, 2016 10:48
ChrisDodd
approved these changes
Nov 5, 2016
| namespace BMV2 { | ||
|
|
||
| const IR::Node* DoCopyStructures::postorder(IR::AssignmentStatement* statement) { | ||
| auto ltype = typeMap->getType(statement->left, true); |
There was a problem hiding this comment.
Shouldn't this be a preorder so that assignments of nested structs will get flattened properly too? However, that would likely require fixing the code to use and maintain the types in the expression nodes properly, rather than the typeMap, which will be out of date after the first flattening.
| "size" | ||
| }; | ||
| for (size_t i=0; i < ELEMENTS(knownProperties); i++) | ||
| if (property->name.name == knownProperties[i]) |
There was a problem hiding this comment.
prefer for (auto propName : knownProperties) for this kind of loop. Or even something like
static std::set<cstring> knownProperties = { ... };
if (!knownProperties.count(property->name))
warning(...
|
merged as 6bd98d1 -- rebase you branch on to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.