Mark BMV2 JSON scalars as 'pi_omit' so they won't be exposed in PI #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
approved these changes
Dec 23, 2016
mihaibudiu
reviewed
Dec 23, 2016
| @@ -1761,6 +1761,7 @@ void JsonConverter::addLocals() { | |||
| json->emplace("id", nextId("headers")); | |||
| json->emplace("header_type", scalarsName); | |||
| json->emplace("metadata", true); | |||
| json->emplace("pi_omit", true); // Don't expose scalars in PI. | |||
There was a problem hiding this comment.
I am using the same scalars struct in the output for storing local variables but also for scalar fields that may have been declared in the user metadata structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch marks the scalars header instance that we synthesize in the BMV2 JSON converter as "pi_omit". The plan is to not expose the scalars in PI, since they're an implementation detail and it doesn't really make sense to interact with them via PI directly.