Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark BMV2 JSON scalars as 'pi_omit' so they won't be exposed in PI #209

Merged
merged 1 commit into from
Dec 23, 2016
Merged

Mark BMV2 JSON scalars as 'pi_omit' so they won't be exposed in PI #209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/bmv2/jsonconverter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1761,6 +1761,7 @@ void JsonConverter::addLocals() {
json->emplace("id", nextId("headers"));
json->emplace("header_type", scalarsName);
json->emplace("metadata", true);
json->emplace("pi_omit", true); // Don't expose scalars in PI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using the same scalars struct in the output for storing local variables but also for scalar fields that may have been declared in the user metadata structure.

headerInstances->append(json);
}

Expand Down