Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing primary key column for DOIDatasets object #133

Closed
kauberry opened this issue May 2, 2018 · 0 comments · Fixed by #135
Closed

Fixing primary key column for DOIDatasets object #133

kauberry opened this issue May 2, 2018 · 0 comments · Fixed by #135

Comments

@kauberry
Copy link
Contributor

kauberry commented May 2, 2018

The DOI reference itself is guaranteed unique, so we don't need a separate numeric id column

kauberry added a commit to kauberry/pacifica-metadata that referenced this issue May 2, 2018
… a proper primary key.

updating the psycopg2 package in requirements to reflect its new naming (psycopg2-binary)

Fixes pacifica#133
dmlb2000 added a commit that referenced this issue May 2, 2018
* quick fix forgot to remove from ES

* we need to upload an example to elasticsearch

* we need to create es mappings to not freak out

* Tweaking the peewee code for generating the DOIDatasets object to use a proper primary key.
updating the psycopg2 package in requirements to reflect its new naming (psycopg2-binary)

Fixes #133

* syntax fixes

* pylint fix

* Fixing test hash in DOIDataSets object

* fix the testing for doi data set

* this needs to be removed as well

* remove primary key in where args
kauberry added a commit to kauberry/pacifica-metadata that referenced this issue May 3, 2018
…3-doidatasets_primary_key

* commit 'cd3f2627700bf2f21eee75acd1c6f57816d2fd4b':
  fix pacifica#133 doidataset primary key (pacifica#135)
dmlb2000 pushed a commit that referenced this issue May 4, 2018
* Tweaking the peewee code for generating the DOIDatasets object to use a proper primary key.
updating the psycopg2 package in requirements to reflect its new naming (psycopg2-binary)

Fixes #133

* syntax fixes

* pylint fix

* Fixing test hash in DOIDataSets object

* more ID fixes

* Final changes to TransactionReleaseState

* Unit test fixes

* testing and code climate fixes

* Does everyone hate CodeClimate, or is it just me?

* more syntax fixes

* formatting fix

* Unit test fixes

* more fixes

* Rolling this change back

* Rolling back this requirements change

* Retrying failed travis run

* Why the Hell does Travis constantly crash???
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant