-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 133 doidatasets primary key #136
Issue 133 doidatasets primary key #136
Conversation
… a proper primary key. updating the psycopg2 package in requirements to reflect its new naming (psycopg2-binary) Fixes pacifica#133
…3-doidatasets_primary_key * commit 'cd3f2627700bf2f21eee75acd1c6f57816d2fd4b': fix pacifica#133 doidataset primary key (pacifica#135)
metadata/rest/test/test_orm.py
Outdated
@@ -126,7 +126,7 @@ def test_perf_of_large_insert(self): | |||
data=txt_trans, headers=self.headers) | |||
self.assertEqual(req.status_code, 200) | |||
end_time = time() | |||
self.assertTrue(end_time - start_time < 90) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted... or we should document justification for changing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rolling this one back. This test was failing multiple times, but I think it was just Travis misbehaving.
requirements-dev.txt
Outdated
@@ -7,7 +7,7 @@ mock | |||
nose | |||
peewee>2 | |||
pep257 | |||
psycopg2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed, why is this different from the normal package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are renaming the package from psycopg2 to psycopg2-binary and deprecating the old name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
psycopg/psycopg2#674 this bug has links to the discussion and plan moving forward. The package specified is going to be a source only build. Which is fine for travis.
requirements.txt
Outdated
@@ -1,7 +1,7 @@ | |||
cherrypy | |||
elasticsearch | |||
peewee>2 | |||
psycopg2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Description
[Describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves]
Check List