Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token, username and password options to stub service #118

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

mefellows
Copy link
Member

@mefellows mefellows commented Jan 15, 2020

Fixes #82.

Exposes the following new flags:

  -n, [--broker-username=BROKER_USERNAME]  # Pact Broker basic auth username
  -p, [--broker-password=BROKER_PASSWORD]  # Pact Broker basic auth password
  -k, [--broker-token=BROKER_TOKEN]        # Pact Broker bearer token

You may also specify the token via the env var PACT_BROKER_TOKEN.

There wasn't an obvious place to add tests for this, but seemed like a good thing to get in as a draft PR for review.

@bethesque
Copy link
Member

LGTM.

@bethesque bethesque merged commit 76236d8 into master Jan 17, 2020
@bethesque bethesque deleted the feat/broker-auth branch January 17, 2020 02:14
themichaelyan pushed a commit to animoto/pact-mock_service that referenced this pull request Feb 4, 2022
* feat: allow mock service host to be configured

pact-foundation/pact-ruby#186

* chore(release): version 3.0.0

* fix: add missing host argument to server spawn

fixes: pact-foundation#102

* chore(release): version 3.0.1

* Improve logging robustness

Do not pretty print a JSON object when serialization or serialization fail, for details see pact-foundation#103.

* Update interaction_replay.rb

* Initial version of the unit test

* Move the test to appropriate context

* Update interaction_replay_spec.rb

* Update interaction_replay_spec.rb

* Update interaction_replay_spec.rb

* Update interaction_replay_spec.rb

* Update interaction_replay.rb

* Update interaction_replay_spec.rb

* Update interaction_replay_spec.rb

* feat: pact-stub-service log level cli opt

* chore(release): version 3.1.0

* chore(release): version 3.1.1

* feat(skip writing to pact): Use writable_interactions when writing to pact file

* Add test for #as_json

* Add feature spec

* Bump pact-support dependency

* Fix tests

* chore(release): version 3.2.0

* CI: Add 2.7 to travis ci

* fix: remove apparently unused require for thwait

* chore(release): version 3.2.1

* feat: log a warning when too many interactions are set on the mock service at once

* chore(release): version 3.3.0

* fix: put metadata on the correct decorator

* chore(release): version 3.3.1

* chore: remove jruby until somebody shows they're actually using it

* chore(release): version 3.4.0

* feat: add token, username and password options to stub service (pact-foundation#118)

Co-authored-by: Beth Skurrie <bethesque@users.noreply.github.com>

* chore(release): version 3.5.0

* docs: document that you can set the broker token via an env var

[ci-skip]

* chore: separate test and deploy stages

* chore: update .travis.yml

[ci-skip]

* chore: update .travis.yml

* test: add expectations to make sure metadata: nil isn't stored in the pact (pact-foundation#119)

* feat: add 'Access-Control-Allow-Headers' = true to cors response headers (pact-foundation#121)

* chore(release): version 3.6.0

* fix:  fix Ruby 2.7 kwargs warning (pact-foundation#122)

* chore(release): version 3.6.1

* fix: update thor dependency (pact-foundation#124)

Co-authored-by: Lindsey Hattamer <lindsey.hattamer@oddball.io>

Co-authored-by: Lindsey Hattamer <lindsey.hattamer@oddball.io>

* chore: add github workflow for gem release

* chore: disable tests as they're not running properly on github workflow

* chore(release): version 3.6.2

* feat: do not require files until command is executing

* chore: update release workflow [ci-skip]

* feat: use Pact::Query.parse_string to parse query string

* chore(deps): update rake

* docs: update travis badge

* chore(release): version 3.7.0

* feat: include interaction diffs in verification response

cc: @TimothyJones

* chore: add tests to github actions

* chore: allow workflow dispatch to release

* chore(release): version 3.8.0

* chore: tests are hanging. try a subset

* chore: try rspec

* chore: disabling tests, they hang

* chore: create issue template

* feat: pass host into WEBrick options to allow configuration (pact-foundation#128)

Co-authored-by: Matthew Hall <matthew.hall@partnerize.com>

* chore(release): version 3.9.0

* chore: handle http 2

* fix: check for nil body rather than falsey body when determining how to render mocked response
Fixes: pact-foundation#99

* chore(release): version 3.9.1

Co-authored-by: Beth Skurrie <beth@bethesque.com>
Co-authored-by: Alexander Bolshakov <lextiz@gmail.com>
Co-authored-by: YOU54F <yousafn@gmail.com>
Co-authored-by: Beth Skurrie <bethesque@users.noreply.github.com>
Co-authored-by: Simon Nizov <simon.nizov@gmail.com>
Co-authored-by: Chavez <matthew@el-chavez.me>
Co-authored-by: Chavez <mtchavez@users.noreply.github.com>
Co-authored-by: Matt Fellows <matt.fellows@onegeek.com.au>
Co-authored-by: vandemark <jnvbeach@gmail.com>
Co-authored-by: Bartek Bułat <barthez@users.noreply.github.com>
Co-authored-by: Michael R. Fleet <f1337@users.noreply.github.com>
Co-authored-by: Lindsey Hattamer <lindsey.hattamer@oddball.io>
Co-authored-by: mhall58 <matthewhall58@gmail.com>
Co-authored-by: Matthew Hall <matthew.hall@partnerize.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: allow stub server to source contracts from broker
2 participants