fix(plugin-driver): use std:process over tokio for plugin loads on al… #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YOU54F
added a commit
to YOU54F/pact-avro-plugin
that referenced
this pull request
Aug 19, 2024
YOU54F
added a commit
to YOU54F/pact-avro-plugin
that referenced
this pull request
Aug 19, 2024
YOU54F
force-pushed
the
fix/issue-68_replace_tokio_process
branch
from
a7e0302
to
f332bca
Compare
relates to tokio-rs/tokio#3520 Signals do not add SA_ONSTACK which may cause linked Go applications to crash. fixes pact-foundation#68 fixes pact-foundation/pact-go#269 windows plugin shutdowns, terminate child processes
YOU54F
force-pushed
the
fix/issue-68_replace_tokio_process
branch
from
0592f88
to
1473cc6
Compare
This was referenced Aug 21, 2024
|
Tested and working in (using an ffi forked release - https://github.com/you54f/pact-reference/releases/tag/libpact_ffi-v0.4.33)
For avro plugin usage, tested with this PR applied austek/pact-avro-plugin#45 Released a fork https://github.com/austek/pact-avro-plugin/releases/tag/v0.0.6 |
|
Good to go now, avro plugin is released. pr failures are expected, passing in an branch against origin https://github.com/pact-foundation/pact-plugins/tree/fix/issue-68_replace_tokio_process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l os
fixes tokio-rs/tokio#3520
Signals do not add SA_ONSTACK which may cause linked Go applications to crash.
fixes #68
fixes pact-foundation/pact-go#269
fixes #73
note: std::process unable to read pact-avro-plugin startup message see #68 for detail