chore(v3)!: remove unnecessary underscores #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arguments to `__exit__` are not used. When first implemented, this
used the leading underscores to make that explicit; however, this is
incompatible with the expected type signature of the function.
BREAKING CHANGE: The PactServer `__exit__` arguments no longer have
leading underscores. This is typically handled by Python itself and
therefore is unlikely to be a change for any user, unless the end
user was calling the `__exit__` method explicitly _and_ using
keyword arguments.
Signed-off-by: JP-Ellis <josh@jpellis.me>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
===================================
Coverage 78% 78%
===================================
Files 30 30
Lines 3365 3365
===================================
Hits 2634 2634
Misses 731 731
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The arguments to
__exit__are not used. When first implemented, this used the leading underscores to make that explicit; however, this is incompatible with the expected type signature of the function.🚨 Breaking Changes
The PactServer
__exit__arguments no longer have leading underscores. This is typically handled by Python itself and therefore is unlikely to be a change for any user, unless the end user was calling the__exit__method explicitly and using keyword arguments.🔥 Motivation
Better compatibility with the expected behaviour of
__exit__🔨 Test Plan
CI
🔗 Related issues/PRs
None