chore: [IOBP-804] Added feedback banner mock for the new payment success screen #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
========================================
Coverage 64.28% 64.28%
========================================
Files 167 167
Lines 5362 5362
Branches 731 739 +8
========================================
Hits 3447 3447
+ Misses 1914 1775 -139
- Partials 1 140 +139
... and 34 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
hevelius
requested changes
Oct 15, 2024
package.json
Outdated
| @@ -11,7 +11,7 @@ | |||
| "api_cgn": "https://raw.githubusercontent.com/pagopa/io-backend/v14.3.0-RELEASE/api_cgn.yaml", | |||
| "api_cgn_merchants": "https://raw.githubusercontent.com/pagopa/io-backend/v14.3.0-RELEASE/api_cgn_operator_search.yaml", | |||
| "api_cgn_geo": "https://raw.githubusercontent.com/pagopa/io-backend/here_geoapi_integration/api_geo.yaml", | |||
| "content_specs": "https://raw.githubusercontent.com/pagopa/io-services-metadata/1.0.42/definitions.yml", | |||
| "content_specs": "https://raw.githubusercontent.com/pagopa/io-services-metadata/IOBP-803-add-banner-new-payment-section/definitions.yml", | |||
There was a problem hiding this comment.
It should be update with release version
There was a problem hiding this comment.
The release version has been addressed into bd18145
|
🎉 All dependencies have been resolved ! |
Hantex9
added a commit
to pagopa/io-app
that referenced
this pull request
Oct 17, 2024
…d remote configuration (#6072) ##⚠️ This PR depends on pagopa/io-services-metadata#821⚠️ ## Short description This PR adds the remote feature flag and remote configurations for the feedback banner that will be displayed on the successful payment screen. ## List of changes proposed in this pull request - Adapted the `WalletPaymentFeedbackBanner` to show only if the feature flag is enabled and if it is, shows with a remote content inside; - Added `isPaymentsFeedbackBannerEnabledSelector` to check if the feedback banner should be shown or not; - Added `paymentsFeedbackBannerConfigSelector` to get the banner remote configurations ## How to test - Checkout this PR: pagopa/io-dev-api-server#402 - Run the dev-server - Start a payment from the payments section; - When you reach the "success" page, if the feature flag is enabled with the min_app_version, you should be able to see the feedback banner as shown in the following screenshot; ## Preview <img src="https://github.com/user-attachments/assets/ccb7a9db-c066-40a2-b129-7f3d927bc58c" width="300" /> --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it> Co-authored-by: Alice Di Rico <83651704+Ladirico@users.noreply.github.com>
LeleDallas
approved these changes
Oct 22, 2024
hevelius
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the feedback banner definition and its mock. This property is used to show the feedback banner when the user completes a payment successfully with the new payment flow.
List of changes proposed in this pull request
feedbackBannerproperties insidenewPaymentsSection;How to test
With this PR runned on the dev-server, start the io app in DEV env. and complete a payment flow, you should be able to see a banner with the provided text inside the payment thank you page