chore: [IOBP-803] Add feedback banner definitions into new payment section #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hevelius
requested changes
Oct 15, 2024
Co-authored-by: FrancescaMariaTIberti <86290029+FrancescaMariaTIberti@users.noreply.github.com>
Co-authored-by: FrancescaMariaTIberti <86290029+FrancescaMariaTIberti@users.noreply.github.com>
hevelius
approved these changes
Oct 16, 2024
Hantex9
added a commit
to pagopa/io-app
that referenced
this pull request
Oct 17, 2024
…d remote configuration (#6072) ##⚠️ This PR depends on pagopa/io-services-metadata#821⚠️ ## Short description This PR adds the remote feature flag and remote configurations for the feedback banner that will be displayed on the successful payment screen. ## List of changes proposed in this pull request - Adapted the `WalletPaymentFeedbackBanner` to show only if the feature flag is enabled and if it is, shows with a remote content inside; - Added `isPaymentsFeedbackBannerEnabledSelector` to check if the feedback banner should be shown or not; - Added `paymentsFeedbackBannerConfigSelector` to get the banner remote configurations ## How to test - Checkout this PR: pagopa/io-dev-api-server#402 - Run the dev-server - Start a payment from the payments section; - When you reach the "success" page, if the feature flag is enabled with the min_app_version, you should be able to see the feedback banner as shown in the following screenshot; ## Preview <img src="https://github.com/user-attachments/assets/ccb7a9db-c066-40a2-b129-7f3d927bc58c" width="300" /> --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it> Co-authored-by: Alice Di Rico <83651704+Ladirico@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds definitions for the payment banner feedback adding some reusable types
Banner,BannerActionandLocalizedTextthat provide all the needed properties to show a banner with an optional action.List of changes proposed in this pull request
feedbackBannerunder theNewPaymentSectiondefinition with the provided min version to be visibleBannerproperties with theBannerActionand a reusableLocalizedTextdefinition