Fix private keys are not found on Linux/Windows

[fernandezcuesta]

No description provided.

[pahaz]

#126 this may be related to the same code part

[pahaz]

Sorry for my commit :) feel free to delete it. You are the first %)

[fernandezcuesta]

No problem, I'm booking some time later on and fix this issue. Not as easy as deleting the if condition though.

[pahaz]

Probably we also can use ssh_private_key_password for the default ssh key location. It's also may be helpful for case like so:

tunnel = SSHTunnelForwarder(
    SSH_SERVER_ADDRESS,
    ssh_username=SSH_SERVER_USERNAME,
    ssh_private_key_password=SSH_SERVER_PKEY_PASS,
    remote_bind_address=SSH_SERVER_REMOTE_SIDE_ADDRESS,
)

[pahaz]

And also, #145 is also may be fixed. I think we can check the ~/.ssh path first and then check ~/ssh for windows. But I'm not sure 🤔

[coveralls]

Coverage increased (+1.04%) to 91.64% when pulling 9739703 on fernandezcuesta-patch-161 into cd374d5 on master.

[fernandezcuesta]

regarding #145, I agree on setting ~/.ssh as default config folder for windows as well.