Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export x from './x' syntax not supported? #89

Closed
olalonde opened this issue Jun 25, 2016 · 4 comments
Closed

export x from './x' syntax not supported? #89

olalonde opened this issue Jun 25, 2016 · 4 comments

Comments

@olalonde
Copy link
Contributor

Seems madge doesn't understand "re-export" statements:

./a.js

export const helloStr = 'Hello World !'
export default () => console.log(helloStr)

./b.js

export helloWorld from './a'

./index.js

import * as b from './b'

b.helloWorld()
madge --format es6 --image graph.png ./

Results in the following dependency graph:

graph

It seems as though nothing depends on a.js which is inaccurate.

@olalonde
Copy link
Contributor Author

Sent a PR to node-detective-es6, dependents/node-detective-es6#8 ... hopefully that fixes the issue.

@olalonde
Copy link
Contributor Author

Wrote a PR that fixes this: #91

@olalonde
Copy link
Contributor Author

Image after PR:

graph

@pahen
Copy link
Owner

pahen commented Jun 28, 2016

Fixed in 5deb37f

@pahen pahen closed this as completed Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants