-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for es6 re-export syntax #91
Conversation
e.g.: export { a } from './a'k export a from './a' export * as a from './a'
@@ -50,4 +50,9 @@ describe('module format (ES6)', function () { | |||
format: 'es6' | |||
}).obj().should.eql({ 'async': [ 'absolute/b' ] }); | |||
}); | |||
it('should should support export x from "./file"', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider removing the extra should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also consider placing a newline before this for even spacing about the it
s
Nice work here @olalonde! Thanks for contributing! |
Thanks. fixed your comments. I had copied the test above which also read "should should" so fixed both. |
👍 |
I'm on vacation now but will take a look at this as soon I'm back :) lördag 25 juni 2016 skrev Joel Kemp notifications@github.com:
/Patrik |
Nice work! Very appreciated :-) |
* Add support for re-export syntax e.g.: export { a } from './a'k export a from './a' export * as a from './a' * update npm-shrinkwrap.json * should should -> should, ^1.1.5 -> 1.1.5
e.g.: