Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for es6 re-export syntax #91

Merged
merged 3 commits into from
Jun 28, 2016
Merged

Support for es6 re-export syntax #91

merged 3 commits into from
Jun 28, 2016

Conversation

olalonde
Copy link
Contributor

@olalonde olalonde commented Jun 25, 2016

e.g.:

export { a } from './a'k
export a from './a'
export * as a from './a'

e.g.:

export { a } from './a'k
export a from './a'
export * as a from './a'
@olalonde olalonde changed the title Support for re-export, WIP Support for re-export Jun 25, 2016
@olalonde olalonde changed the title Support for re-export Support for es6 re-export syntax Jun 25, 2016
@@ -50,4 +50,9 @@ describe('module format (ES6)', function () {
format: 'es6'
}).obj().should.eql({ 'async': [ 'absolute/b' ] });
});
it('should should support export x from "./file"', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider removing the extra should

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider placing a newline before this for even spacing about the its

@mrjoelkemp
Copy link
Contributor

Nice work here @olalonde! Thanks for contributing!

@olalonde
Copy link
Contributor Author

Thanks. fixed your comments. I had copied the test above which also read "should should" so fixed both.

@mrjoelkemp
Copy link
Contributor

👍

@pahen
Copy link
Owner

pahen commented Jun 25, 2016

I'm on vacation now but will take a look at this as soon I'm back :)

lördag 25 juni 2016 skrev Joel Kemp notifications@github.com:

👍


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#91 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAVmYKwuSj04-l6j0vhlz0kWFKsnkQYYks5qPRrigaJpZM4I-RFq
.

/Patrik

@pahen
Copy link
Owner

pahen commented Jun 28, 2016

Nice work! Very appreciated :-)

@pahen pahen merged commit 5deb37f into pahen:master Jun 28, 2016
nmeylan pushed a commit to nmeylan/madge that referenced this pull request Jan 7, 2020
* Add support for re-export syntax

e.g.:

export { a } from './a'k
export a from './a'
export * as a from './a'

* update npm-shrinkwrap.json

* should should -> should, ^1.1.5 -> 1.1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants