Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint fixes #79

Merged
merged 2 commits into from
Mar 22, 2020
Merged

eslint fixes #79

merged 2 commits into from
Mar 22, 2020

Conversation

sghael
Copy link
Contributor

@sghael sghael commented Mar 21, 2020

Goal of the pull request:

  • Fix eslint warning/errors
> eslint src/*.js


/Users/.../development/ebay-node-api/src/buildURL.js
  2:1  error  Expected line before comment  lines-around-comment
  8:5  error  Expected line before comment  lines-around-comment

/Users/.../development/ebay-node-api/src/findingApi.js
   24:8  warning  Unexpected console statement  no-console
   37:8  warning  Unexpected console statement  no-console
   58:8  warning  Unexpected console statement  no-console
   78:8  warning  Unexpected console statement  no-console
   88:8  warning  Unexpected console statement  no-console
  107:8  warning  Unexpected console statement  no-console

/Users/.../development/ebay-node-api/src/merchandising.js
  20:9  warning  Unexpected console statement  no-console
  33:5  warning  Unexpected console statement  no-console
  37:9  warning  Unexpected console statement  no-console

/Users/.../development/ebay-node-api/src/request.js
   7:24  error  Unexpected function expression  prefer-arrow-callback
  47:24  error  Unexpected function expression  prefer-arrow-callback

/Users/.../development/ebay-node-api/src/shopping.js
  14:8  warning  Unexpected console statement  no-console
  28:8  warning  Unexpected console statement  no-console
  40:8  warning  Unexpected console statement  no-console
  57:8  warning  Unexpected console statement  no-console

✖ 17 problems (4 errors, 13 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

Description

src/merchandising.js Outdated Show resolved Hide resolved
Remove erroneous console
@pajaydev
Copy link
Owner

@sghael Thanks 👍

@pajaydev pajaydev merged commit 7332417 into pajaydev:master Mar 22, 2020
sghael added a commit to sghael/ebay-node-api that referenced this pull request Mar 22, 2020
@sghael sghael deleted the eslint-fixes branch September 3, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants