Merge pull request #1 from pajaydev/master

eslint fixes (pajaydev#79)
sghael · Mar 22, 2020 · 1cff8af · 1cff8af
2 parents 6614677 + 7332417
commit 1cff8af
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 19 deletions.
diff --git a/src/buildURL.js b/src/buildURL.js
@@ -1,10 +1,12 @@
 'use strict';
+
 /**
  * This method is used to build the url based on
  * the type of request.
  */
 
 const buildURL = {
+
     /**
    * Builds the findings(search)  URL.
    *

diff --git a/src/findingApi.js b/src/findingApi.js
@@ -20,8 +20,7 @@ const findItemsByKeywords = function (options) {
     const url = urlObject.buildSearchUrl(this.options);
     return getRequest(url).then((data) => {
         return JSON.parse(data).findItemsByKeywordsResponse;
-
-    }, console.error
+    }, console.error // eslint-disable-line no-console
     );
 };
 
@@ -33,8 +32,7 @@ const findItemsByCategory = function (categoryID) {
     const url = urlObject.buildSearchUrl(this.options);
     return getRequest(url).then((data) => {
         return JSON.parse(data).findItemsByCategoryResponse;
-
-    }, console.error
+    }, console.error // eslint-disable-line no-console
     );
 };
 
@@ -55,7 +53,7 @@ const findCompletedItems = function (options) {
     return getRequest(url).then((data) => {
         return JSON.parse(data).findCompletedItemsResponse;
 
-    }, console.error
+    }, console.error // eslint-disable-line no-console
     );
 };
 
@@ -75,7 +73,7 @@ const findItemsAdvanced = function (options) {
     const url = urlObject.buildSearchUrl(this.options);
     return getRequest(url).then((data) => {
         return JSON.parse(data).findItemsAdvancedResponse;
-    }, console.error
+    }, console.error // eslint-disable-line no-console
     );
 };
 
@@ -85,7 +83,7 @@ const getVersion = function () {
     const url = urlObject.buildSearchUrl(this.options);
     return getRequest(url).then((data) => {
         return JSON.parse(data).getVersionResponse[0];
-    }, console.error
+    }, console.error // eslint-disable-line no-console
     );
 };
 
@@ -104,7 +102,7 @@ const findItemsByProduct = function (options) {
     return getRequest(url).then((data) => {
         return JSON.parse(data).findItemsByProductResponse;
 
-    }, console.error
+    }, console.error // eslint-disable-line no-console
     );
 };
 

diff --git a/src/merchandising.js b/src/merchandising.js
@@ -17,7 +17,7 @@ const getMostWatchedItems = function (merchOptions) {
     return getRequest(`http://${this.options.baseSvcUrl}/${MERCH_SRVC_NAME}?OPERATION-NAME=getMostWatchedItems&SERVICE-NAME=${MERCH_SRVC_NAME}&SERVICE-VERSION=1.1.0&CONSUMER-ID=${this.options.clientID}&RESPONSE-DATA-FORMAT=JSON&REST-PAYLOAD${url}`).then((result) => {
         return JSON.parse(result);
     }).catch((error) => {
-        console.log(error);
+        console.log(error); // eslint-disable-line no-console
     });
 };
 
@@ -30,11 +30,10 @@ const getMostWatchedItems = function (merchOptions) {
 const getSimilarItems = function (merchOptions) {
     if (!this.options.clientID) throw new Error('Missing App id or client id');
     const url = parseObj(merchOptions);
-    console.log(`http://${this.options.baseSvcUrl}/${MERCH_SRVC_NAME}?OPERATION-NAME=getSimilarItems&SERVICE-NAME=${MERCH_SRVC_NAME}&SERVICE-VERSION=1.1.0&CONSUMER-ID=${this.options.clientID}&RESPONSE-DATA-FORMAT=JSON&REST-PAYLOAD${url}`);
     return getRequest(`http://${this.options.baseSvcUrl}/${MERCH_SRVC_NAME}?OPERATION-NAME=getSimilarItems&SERVICE-NAME=${MERCH_SRVC_NAME}&SERVICE-VERSION=1.1.0&CONSUMER-ID=${this.options.clientID}&RESPONSE-DATA-FORMAT=JSON&REST-PAYLOAD${url}`).then((result) => {
         return JSON.parse(result);
     }).catch((error) => {
-        console.log(error);
+        console.log(error); // eslint-disable-line no-console
     });
 };
 

diff --git a/src/request.js b/src/request.js
@@ -4,7 +4,7 @@ const qs = require('querystring');
 
 const getRequest = (url) => {
     if (url.includes('http://')) httpRequest = require('http');
-    return new Promise(function (resolve, reject) {
+    return new Promise(((resolve, reject) => {
         httpRequest.get(url, res => {
             res.setEncoding('utf8');
             let body = '';
@@ -22,7 +22,7 @@ const getRequest = (url) => {
 
             });
         });
-    });
+    }));
 };
 
 const makeRequest = function postRequest(self, endpoint, methodName, token) {
@@ -44,7 +44,7 @@ const makeRequest = function postRequest(self, endpoint, methodName, token) {
             ...self.headers
         }
     };
-    return new Promise(function (resolve, reject) {
+    return new Promise(((resolve, reject) => {
         const req = httpRequest.request(options, res => {
             res.setEncoding('utf8');
             let body = '';
@@ -64,7 +64,7 @@ const makeRequest = function postRequest(self, endpoint, methodName, token) {
         //console.log('request ' + dataString);
         if (methodName === 'POST') req.write(dataString);
         req.end();
-    });
+    }));
 };
 
 

diff --git a/src/shopping.js b/src/shopping.js
@@ -11,7 +11,7 @@ const getAllCategories = function (categoryID) {
     const url = urlObject.buildShoppingUrl(this.options);
     return getRequest(url).then((data) => {
         return JSON.parse(data);
-    }, console.error
+    }, console.error // eslint-disable-line no-console
     );
 };
 
@@ -25,7 +25,7 @@ const getUserDetails = function (input) {
     const url = urlObject.buildShoppingUrl(this.options);
     return getRequest(url).then((data) => {
         return JSON.parse(data);
-    }, console.error
+    }, console.error // eslint-disable-line no-console
     );
 };
 
@@ -37,7 +37,7 @@ const getItemStatus = function (itemIds) {
     const url = urlObject.buildShoppingUrl(this.options);
     return getRequest(url).then((data) => {
         return JSON.parse(data);
-    }, console.error
+    }, console.error // eslint-disable-line no-console
     );
 };
 
@@ -54,7 +54,7 @@ const getShippingCosts = function (input) {
     url = url + params;
     return getRequest(url).then((data) => {
         return JSON.parse(data);
-    }, console.error
+    }, console.error // eslint-disable-line no-console
     );
 };