Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filesystem SBOM capability #370

Merged
merged 4 commits into from
Apr 18, 2022
Merged

Add filesystem SBOM capability #370

merged 4 commits into from
Apr 18, 2022

Conversation

sophiewigmore
Copy link
Member

Summary

Resolves #368

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sophiewigmore sophiewigmore added the semver:minor A change requiring a minor version bump label Apr 13, 2022
@sophiewigmore sophiewigmore requested a review from a team as a code owner April 13, 2022 15:52
@robdimsdale
Copy link
Member

This looks great to me!

Just an FYI - I had to upgrade to golang 1.18 in order to get the tests to pass. It's possible my local golang was corrupted - I haven't had chance to check with other versions of golang - but it might also be worth updating the go.mod to require go 1.18.

@sophiewigmore
Copy link
Member Author

@robdimsdale thanks for checking this over! I'll do that.

@thitch97 thitch97 merged commit 8684022 into main Apr 18, 2022
@thitch97 thitch97 deleted the sbom branch April 18, 2022 15:43
This was referenced Apr 26, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thitch97 thitch97 thitch97 approved these changes

@dmikusa dmikusa Awaiting requested review from dmikusa dmikusa is a code owner automatically assigned from paketo-buildpacks/php-maintainers

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/php-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conform to Paketo RFC0038: Generate SBOM on filesystem as well as label metadata
3 participants
@sophiewigmore @robdimsdale @thitch97