Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate filesystem based SBOM for pip dependency #250

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

robdimsdale
Copy link
Member

Summary

Add support for filesystem-based SBOM, in addition to the existing metadata-label-based BOM, in order to conform with: Paketo RFC0038.

Closes #213

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@robdimsdale robdimsdale requested a review from a team as a code owner April 21, 2022 01:41
@robdimsdale robdimsdale added the semver:minor A change requiring a minor version bump label Apr 21, 2022
@sophiewigmore
Copy link
Member

Hey @paketo-buildpacks/python-maintainers! I'm reviewing this PR because its similar to others I've recently reviewed and seems like a time-saver since I have context. Feel free to also review it if you see fit!

I'm not a maintainer, but I am a contributor. I have also worked on a number of similar PRs to implement filesystem SBOM in other buildpacks (example), as well as reviewed a number of related PRs (example).

@thitch97 thitch97 merged commit f4f7cae into main Apr 26, 2022
@thitch97 thitch97 deleted the filesystem-sbom branch April 26, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conform to Paketo RFC0038: Generate SBOM on filesystem as well as label metadata
3 participants