-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Identity #115
Merged
Merged
PR Identity #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when a PR was created the author for the create commit was the "actor" in the action. In actions based on schedules, this actor is the author of the last commit; the commit that the action reads its workflow from. This behavior lead to commits appearing to come from real users rather than the robots that were creating the PRs. This change updates the author of the created commits to always be the same bot that is creating the PR. Signed-off-by: Ben Hale <bhale@vmware.com>
nebhale
added
semver:patch
A change requiring a patch version bump
type:enhancement
A general enhancement
labels
Nov 18, 2020
ekcasey
approved these changes
Nov 19, 2020
This was referenced Dec 18, 2020
ghost
mentioned this pull request
Dec 18, 2020
This was referenced Dec 18, 2020
ghost
mentioned this pull request
Dec 18, 2020
This was referenced Dec 18, 2020
ghost
mentioned this pull request
Dec 18, 2020
This was referenced Dec 18, 2020
This was referenced Dec 18, 2020
This was referenced Dec 18, 2020
This was referenced Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a PR was created the author for the create commit was the "actor" in the action. In actions based on schedules, this actor is the author of the last commit; the commit that the action reads its workflow from. This behavior lead to commits appearing to come from real users rather than the robots that were creating the PRs.
This change updates the author of the created commits to always be the same bot that is creating the PR.