Fixes version ordering for GraalVM dependencies #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we normalizing GraalVM versions into semver format before sorting. With the release of 21.0.0.2 this caused a bug where version 21.0.0 was overwriting version 21.0.0.2 in the canidate map, causing version 21.0.0.2 to be ignored. With this change we no longer convert to semver before sorting and instead use a simple alphanumeric sort. This is a quick fix and might be fragile to changes such as the introduction of pre-releases releases for release candidates. Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey
added
type:bug
This was referenced Mar 11, 2021
ghost
mentioned this pull request
This was referenced Mar 11, 2021
ghost
mentioned this pull request
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
ghost
mentioned this pull request
This was referenced Mar 11, 2021
ghost
mentioned this pull request
ghost
mentioned this pull request
This was referenced Mar 11, 2021
ghost
mentioned this pull request
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
This was referenced Mar 19, 2021
This was referenced May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we normalizing GraalVM versions into semver format before sorting. With the release of 21.0.0.2 this caused a bug where version 21.0.0 was overwriting version 21.0.0.2 in the canidate map, causing version 21.0.0.2 to be ignored. With this change we no longer convert to semver before sorting and instead use a simple alphanumeric sort.