Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag filtering for offline_packages and republish_images #543

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

andrew-su
Copy link
Contributor

@andrew-su andrew-su commented Feb 8, 2022

Summary

This change addresses #537. It adds a new parameter of tag_prefix which by default is empty. If it is specified, only tags with that specific prefix is listed.

If the tag was my-buildpack/v1.2.3 then the expected tag_prefix should be my-buildpack/.

Use Cases

Some repos may use a prefix on their tags. For example: my-buildpack/v1.2.3, my-buildpack/2.3.4 or my-buildpack-v1.2.3

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@andrew-su andrew-su requested a review from a team February 8, 2022 05:21
@andrew-su andrew-su force-pushed the andrew-su/version-search branch from a785b13 to 8b267b8 Compare February 8, 2022 05:30
@dmikusa dmikusa added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Feb 8, 2022
@dmikusa
Copy link
Contributor

dmikusa commented Feb 8, 2022

@andrew-su - Sorry. Not sure if I should have merged these in the opposite order, but there are some merge conflicts now. Do you have a chance to take a look and resolve them? Thanks

@andrew-su andrew-su force-pushed the andrew-su/version-search branch from 8b267b8 to e6fbd00 Compare February 8, 2022 17:04
I decided to only handle prefixes. So anything where the version number
is at the end of the tag.

Signed-off-by: Andrew Su <suan@vmware.com>
@andrew-su andrew-su force-pushed the andrew-su/version-search branch from e6fbd00 to 2a7fc37 Compare February 8, 2022 17:07
@andrew-su
Copy link
Contributor Author

I didn't base the work here off the other branch, I've rebased it now.

@dmikusa
Copy link
Contributor

dmikusa commented Feb 8, 2022

Thanks!

@dmikusa dmikusa merged commit af704ca into paketo-buildpacks:main Feb 9, 2022
This was referenced Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants