Pass the OS from the source image to the target #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently, images generated with 'update-buildpack-image-id' will have the OS='' (empty string). This is not being copied over from the source image, which has the OS set. This PR changes it so that the value from the source image is set on the target image. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:bug
pivotal-david-osullivan
approved these changes
Aug 29, 2022
This was referenced Aug 30, 2022
This was referenced Aug 30, 2022
This was referenced Aug 30, 2022
This was referenced Sep 22, 2022
This was referenced Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, images generated with 'update-buildpack-image-id' will have the OS='' (empty string). This is not being copied over from the source image, which has the OS set. This PR changes it so that the value from the source image is set on the target image.
Signed-off-by: Daniel Mikusa dmikusa@vmware.com