Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tomee #102 #922

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Fix Tomee #102 #922

merged 1 commit into from
Nov 25, 2022

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Nov 25, 2022

Summary

The new RC versions have a period instead of a dash in the version number. This broke the regular expression and the way download URLs were being generated. This change adjusts the regex and generated download URLs accordingly.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

The new RC versions have a period instead of a dash in the version number. This broke the regular expression and the way download URLs were being generated. This change adjusts the regex and generated download URLs accordingly.

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Nov 25, 2022
@dmikusa dmikusa requested a review from a team November 25, 2022 04:20
@dmikusa dmikusa merged commit a892992 into main Nov 25, 2022
@dmikusa dmikusa deleted the tomee-fix branch November 25, 2022 04:34
This was referenced Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant