-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jitter to "Update Go" action schedule #979
Merged
dmikusa
merged 1 commit into
paketo-buildpacks:main
from
sap-contributions:add-jitter-to-update-go
Jan 24, 2023
Merged
Add Jitter to "Update Go" action schedule #979
dmikusa
merged 1 commit into
paketo-buildpacks:main
from
sap-contributions:add-jitter-to-update-go
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikusa
requested changes
Jan 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this. This was a high priority fix.
Two very minor notes around doc and I think this should be good to merge.
dmikusa
added
semver:minor
A change requiring a minor version bump
type:enhancement
A general enhancement
labels
Jan 21, 2023
phil9909
force-pushed
the
add-jitter-to-update-go
branch
from
January 23, 2023 10:39
55b1f52
to
aa78e4d
Compare
dmikusa
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks very much!
This was referenced Jan 31, 2023
This was referenced Jan 31, 2023
This was referenced Jan 31, 2023
This was referenced Jan 31, 2023
This was referenced Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #966 by adding a Jitter to the cron schedule (Alternative 2 in the issue)
The jitter is seeded with the repo name (
GITHUB_REPOSITORY
env) and will there produce a constant value for the same repo (unless renamed).It is implemented in a separate package to be easily reused in other actions that might profit from this as well.
Use Cases
Prevent rate limiting
Checklist