Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to newer lifecycle and pack versions #11

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Aug 14, 2023

Summary

update to newer version of lifecycle and pack

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson mhdawson requested a review from a team as a code owner August 14, 2023 23:00
@mhdawson
Copy link
Member Author

Thanks to @natalieparellano who figured out the part about how to use the registry in the scripts.

I had to put the docker stop where it is as anywhere later and it did not seem to run. I suspect something to do with how the go test results are output but not sure.

@robdimsdale
Copy link
Member

I had to put the docker stop where it is as anywhere later and it did not seem to run. I suspect something to do with how the go test results are output but not sure.

Yeah, the util::print::success and util::print::error functions exit after printing, so that makes sense. Ideally we would refactor this to be clearer (e.g. using trap or similar), but it should work for now.

More generally, can you help me understand why we now need a registry? What is different from the other builder tests that run directly against the docker engine?

@natalieparellano
Copy link

can you help me understand why we now need a registry

When extending images, we use kaniko, which requires a manifest (or more specifically, a v1.Image implementation) so we need the image to exist in a registry in order to pull the data.

@robdimsdale
Copy link
Member

When extending images, we use kaniko, which requires a manifest (or more specifically, a v1.Image implementation) so we need the image to exist in a registry in order to pull the data.

Ah. I didn't realize that. So it would be more accurate to say that we have always needed a registry for this builder, we just hadn't added it yet.

@@ -1,3 +1,3 @@
{
"pack": "v0.30.0-pre2"
"pack": "v0.30.0-rc2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think pack v0.30.0 just got released so we can fix this, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, I assume it should be good, smoke tests run on PR should confirm.

scripts/.util/tools.json Outdated Show resolved Hide resolved
@mhdawson
Copy link
Member Author

@robdimsdale

Ah. I didn't realize that. So it would be more accurate to say that we have always needed a registry for this builder, we just hadn't added it yet.

Correct, except that because of an earlier bug in pack it at least seemed to run/work before.

@robdimsdale
Copy link
Member

Ah ok. Thanks. I'm not as familiar with extensions so I'm just trying to follow along.

@ForestEckhardt ForestEckhardt merged commit ac5a79c into paketo-community:main Aug 22, 2023
2 checks passed
@mhdawson mhdawson mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants