-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to newer lifecycle and pack versions #11
Conversation
Signed-off-by: Michael Dawson <mdawson@devrus.com>
Thanks to @natalieparellano who figured out the part about how to use the registry in the scripts. I had to put the |
Yeah, the More generally, can you help me understand why we now need a registry? What is different from the other builder tests that run directly against the docker engine? |
When extending images, we use kaniko, which requires a manifest (or more specifically, a |
Ah. I didn't realize that. So it would be more accurate to say that we have always needed a registry for this builder, we just hadn't added it yet. |
scripts/.util/tools.json
Outdated
@@ -1,3 +1,3 @@ | |||
{ | |||
"pack": "v0.30.0-pre2" | |||
"pack": "v0.30.0-rc2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think pack v0.30.0 just got released so we can fix this, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, I assume it should be good, smoke tests run on PR should confirm.
Correct, except that because of an earlier bug in pack it at least |
Ah ok. Thanks. I'm not as familiar with extensions so I'm just trying to follow along. |
Summary
update to newer version of lifecycle and pack
Use Cases
Checklist