Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to newer lifecycle and pack versions #11

Merged
merged 2 commits into from
Aug 22, 2023
Merged

feat: update to newer lifecycle and pack versions #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42e1d73
feat: update to newer lifecycle and pack versions
mhdawson Aug 14, 2023
8f398bd
Update scripts/.util/tools.json
mhdawson Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builder.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description = "Ubi 8 base image with buildpacks for Node.js"
version = "1.7.0"

[lifecycle]
version = "0.17.0-pre.2"
version = "0.17.0"

[[order]]
[[order.group]]
Expand Down
2 changes: 1 addition & 1 deletion scripts/.util/tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"pack": "v0.30.0-pre2"
"pack": "v0.30.0"
}
11 changes: 8 additions & 3 deletions scripts/smoke.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@ function main() {

tools::install "${token}"

builder::create "${name}"
image::pull::lifecycle "${name}"
tests::run "${name}"
reg=$(docker run -d -p5000:5000 registry:2)
builder::create "localhost:5000/${name}"
docker push "localhost:5000/${name}"
tests::run "localhost:5000/${name}" $reg
}

function usage() {
Expand Down Expand Up @@ -106,6 +107,8 @@ function image::pull::lifecycle() {
function tests::run() {
local name
name="${1}"
local reg
reg="${2}"

util::print::title "Run Builder Smoke Tests"

Expand All @@ -114,8 +117,10 @@ function tests::run() {
pushd "${BUILDERDIR}" > /dev/null
if GOMAXPROCS="${GOMAXPROCS:-4}" go test -count=1 -timeout 0 ./smoke/... -v -run Smoke --name "${name}" | tee "${testout}"; then
util::tools::tests::checkfocus "${testout}"
docker stop $reg
util::print::success "** GO Test Succeeded **"
else
docker stop $reg
util::print::error "** GO Test Failed **"
fi
popd > /dev/null
Expand Down
1 change: 1 addition & 0 deletions smoke/nodejs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ func testNodejs(t *testing.T, context spec.G, it spec.S) {

var logs fmt.Stringer
image, logs, err = pack.Build.
WithNetwork("host").
WithPullPolicy("always").
WithBuilder(Builder).
Execute(name, source)
Expand Down