This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Run tests on Java 17 #5753
Closed
Run tests on Java 17 #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
force-pushed
the
ckozak/test_jdk17
branch
from
d283a40 to
f085059
Compare
|
I was OOTO from last week Friday. Will get to this at some point this week. |
|
Gradle 7: @sudiksha27 is actually in the process of doing it! |
|
This PR has been automatically marked as stale because it has not been touched in the last 30 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
sudiksha27
force-pushed
the
ckozak/test_jdk17
branch
from
f085059 to
ce89379
Compare
carterkozak
commented
Mar 29, 2022
Comment on lines
+38
to
+41
| javaVersions { | ||
| libraryTarget = 11 | ||
| runtime = 17 | ||
| } |
There was a problem hiding this comment.
I would expect this to fail if atlasdb still sets javaVersions {... in gradle/versions.gradle.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are failing since atlas hasn't upgraded to Gradle 7 yet
Is anyone looking into taking the plunge?
Goals (and why):
Latest LTS release, I'd like to verify atlasdb can pass tests before upgrading products that use atlasdb code!
Implementation Description (bullets):
Using the new baseline java versions plugin to set java versions for libraries, and the version to use for tests
Testing (What was existing testing like? What have you done to improve it?):
This is that :-D
Concerns (what feedback would you like?):
Where should we start reviewing?:
Priority (whenever / two weeks / yesterday):