This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Latest gradle-baseline #6021
Merged
Latest gradle-baseline #6021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
commented
May 3, 2022
Comment on lines
-304
to
+305
| return (long) (Math.min(BACKOFF_COEFF * Math.pow(2, numberOfAttempts), MAX_EXPECTED_BACKOFF) * randomCoeff); | ||
| return (long) (Math.min(BACKOFF_COEFF * Math.pow(2, numberOfAttempts), (double) MAX_EXPECTED_BACKOFF) | ||
| * randomCoeff); |
There was a problem hiding this comment.
From ./gradlew classes testClasses -PerrorProneApply=LongDoubleConversion
carterkozak
commented
May 3, 2022
| .numBytes(ESTIMATED_NUM_BYTES_PER_ROW * numberOfQueriedRows) | ||
| .numBytes(ESTIMATED_NUM_BYTES_PER_ROW * ((long) numberOfQueriedRows)) |
There was a problem hiding this comment.
From ./gradlew classes testClasses -PerrorProneApply=NarrowCalculation
carterkozak
commented
May 3, 2022
| @@ -323,6 +323,7 @@ public Namespace getNamespace() { | |||
| * | |||
| * @param srcDir root source directory where code generation is performed. | |||
| */ | |||
| @SuppressWarnings("DangerousIdentityKey") | |||
There was a problem hiding this comment.
DangerousIdentityKey suppressions lifted directly from #5753
carterkozak
commented
May 3, 2022
Comment on lines
-75
to
+74
| log.debug( | ||
| "Encountered null metric context likely due to exception in preInvocation: {}", | ||
| UnsafeArg.of("cause", cause), | ||
| cause); | ||
| log.debug("Encountered null metric context likely due to exception in preInvocation", cause); |
There was a problem hiding this comment.
DRY: Logging the cause as a throwable provides everything that cause.toString does, and more!
jeremyk-91
approved these changes
May 3, 2022
| @@ -94,7 +94,7 @@ public void queriesGaugesAgainAfterTimeInterval() { | |||
|
|
|||
| value.set(8); | |||
| tick.addAndGet(DistributionOutlierController.REFRESH_INTERVAL.toNanos() + 1); | |||
| assertThat(defaultController.getMeanGauge().getValue()).isEqualTo(8L); | |||
| assertThat(defaultController.getMeanGauge().getValue()).isEqualTo((double) 8L); | |||
There was a problem hiding this comment.
Suggested change
| assertThat(defaultController.getMeanGauge().getValue()).isEqualTo((double) 8L); | |
| assertThat(defaultController.getMeanGauge().getValue()).isEqualTo(8.0); |
this is fine, and I don't expect us to fix this to get this merged, though this should really be 8.0 (possibly with whatever double equality hacks we need, though none are needed for 8).
More "the existing tests were naughty" rather than anything bad about this change
| @@ -263,7 +263,7 @@ private void flushTask() { | |||
| } | |||
| } catch (Throwable t) { | |||
| if (!Thread.interrupted()) { | |||
| log.warn("Error occurred while flushing sweep stats: {}", UnsafeArg.of("throwable", t), t); | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Latest gradle-baseline
==COMMIT_MSG==