This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Excavator: Upgrades Baseline to the latest version #6214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9578d5b
to
1eff20a
Compare
b06cc6f
to
267c5a7
Compare
267c5a7
to
8f15a40
Compare
Sam-Kramer
reviewed
Sep 23, 2022
...cassandra/src/test/java/com/palantir/atlasdb/keyvalue/cassandra/CassandraClientPoolTest.java
Outdated
Show resolved
Hide resolved
Sam-Kramer
reviewed
Sep 26, 2022
@@ -55,6 +55,7 @@ public void metricsWithOneFilterAreFiltered() { | |||
} | |||
|
|||
@Test | |||
@SuppressWarnings("DistinctVarargsChecker") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DistinctVarargsChecker
throws even for methods, despite that they may return a unique object
Jolyon-S
reviewed
Sep 27, 2022
...db-cassandra/src/test/java/com/palantir/atlasdb/cassandra/backup/RepairRangeFetcherTest.java
Show resolved
Hide resolved
...cassandra/src/test/java/com/palantir/atlasdb/keyvalue/cassandra/CassandraClientPoolTest.java
Outdated
Show resolved
Hide resolved
...ndra/src/test/java/com/palantir/atlasdb/keyvalue/cassandra/ProfilingCassandraClientTest.java
Show resolved
Hide resolved
flake-rule/src/test/java/com/palantir/flake/example/BeforeAndAfterTest.java
Show resolved
Hide resolved
Jolyon-S
approved these changes
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
4.154.0
4.155.0
Automated release, no documented user facing changes
4.156.0
4.157.0
junit-reports
plugin.4.158.0
checkUnusedDependencies
tasks added bybaseline-exact-dependencies
compatible with Gradle's configure-on-demand feature.4.159.0
There is a certain class of very problematic cases whereby if you have
a method such as the following:
<br>myJerseyResource.register(/* this is of type Object */ object);<br>
Then if you supply a resource which includes any
javax.ws.rs
annotations on it, then those will not be registered if your Jersey
version is 3.x or later (and you'll only find this out at runtime).
The opposite is also true if you try to supply resources annotated
with
jakarta.ws.rs
to Jersey 2.x.To address this, this commit attempts to add an errorprone check
which lets implementors add an annotation
@ForbidJavax
to methodswhich have been knowingly migrated to Jakarta EE9 and cannot
accept legacy javax types.
4.160.0
4.161.0
4.162.0
+ support setting preview on a project-by-project basis.
+ Fixes #2340
+ fails more elegantly if javaVersions is set on not-the-root.
4.163.0
4.164.0
CyclomaticComplexity
check is now configured withswitchBlockAsSingleDecisionPoint
.4.165.0
com.palantir.baseline-null-away
which registers theNullAway
check atWARNING
. Projects which fail on warnings will require this to pass pre-merge.4.166.0
Automated release, no documented user facing changes
4.167.0
Automated release, no documented user facing changes
4.168.0
4.169.0
4.170.0
4.171.0
com.palantir.baseline-null-away
no longer enables theCheckOptionalEmptiness
checker by default.4.172.0
Automated release, no documented user facing changes
4.173.0
To enable or disable this check, please contact the maintainers of Excavator.