Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make baseline-exact-dependencies compatible with configure-on-demand #2363

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

AlexLandau
Copy link
Contributor

@AlexLandau AlexLandau commented Aug 18, 2022

Before this PR

With configure-on-demand enabled, these configurations get resolved
before projectsEvaluated triggers are run. (I haven't dug in fully,
but I think this is happening during task graph expansion.)

Make this check more lenient if configure-on-demand is enabled.

After this PR

==COMMIT_MSG==
Make the checkUnusedDependencies tasks added by baseline-exact-dependencies compatible with Gradle's configure-on-demand feature.
==COMMIT_MSG==

Possible downsides?

Unlikely

Verified

This commit was signed with the committer’s verified signature.
Alizter Ali Caglayan
With configure-on-demand enabled, these configurations get resolved
before projectsEvaluated triggers are run. (I haven't dug in fully,
but I think this is happening during task graph expansion.)

Make this check more lenient if configure-on-demand is enabled.
@changelog-app
Copy link

changelog-app bot commented Aug 18, 2022

Generate changelog in changelog/@unreleased

Type
See change types. Select one:

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Make the checkUnusedDependencies tasks added by baseline-exact-dependencies compatible with Gradle's configure-on-demand feature.

Check the box to generate changelog(s)

  • Generate changelog entry

Sorry, something went wrong.

@AlexLandau AlexLandau marked this pull request as ready for review August 18, 2022 19:49
@carterkozak carterkozak requested review from CRogers and fawind August 18, 2022 20:11
@carterkozak
Copy link
Contributor

I've tagged some folks with more historical context than myself to review

@bulldozer-bot bulldozer-bot bot merged commit d9b5b84 into develop Aug 25, 2022
@bulldozer-bot bulldozer-bot bot deleted the alandau/exact-deps-cod branch August 25, 2022 15:07
@svc-autorelease
Copy link
Collaborator

Released 4.158.0

This was referenced Sep 2, 2022
bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Sep 2, 2022
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.154.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | The JUnits reports plugin is no longer applied by default. Test reports now use the standard output locations from Gradle conventions. | palantir/gradle-baseline#2355 |


## 4.155.0
_Automated release, no documented user facing changes_

## 4.156.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | Fix BaselineJavaVersion checkstyle configuration on gradle < 7.5 | palantir/gradle-baseline#2360 |


## 4.157.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Make task initialization lazier in the `junit-reports` plugin. | palantir/gradle-baseline#2364 |


## 4.158.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | Make the `checkUnusedDependencies` tasks added by `baseline-exact-dependencies` compatible with Gradle's configure-on-demand feature. | palantir/gradle-baseline#2363 |


## 4.159.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Add an errorprone check and typed annotation for Javax -> Jakarta<br><br>There is a certain class of very problematic cases whereby if you have<br>a method such as the following:<br><br>```<br>myJerseyResource.register(/* this is of type Object */ object);<br>```<br><br>Then if you supply a resource which includes any `javax.ws.rs`<br>annotations on it, then those will not be registered if your Jersey<br>version is 3.x or later (and you'll only find this out at runtime).<br><br>The opposite is also true if you try to supply resources annotated<br>with `jakarta.ws.rs` to Jersey 2.x.<br><br>To address this, this commit attempts to add an errorprone check<br>which lets implementors add an annotation `@ForbidJavax` to methods<br>which have been knowingly migrated to Jakarta EE9 and cannot<br>accept legacy javax types. | palantir/gradle-baseline#2366 |


## 4.160.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | Workaround to IDEA-301084 | palantir/gradle-baseline#2368 |


## 4.161.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | Reverts a change introduced to baseline-java-version 4.160.0, which was causing failures on multi-project builds. | palantir/gradle-baseline#2369 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants