Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #593

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Nov 23, 2021

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

4.43.0

Type Description Link
Fix BaselineJavaVersions handles the lazy 'nebula.maven-publish' plugin palantir/gradle-baseline#1986

4.44.0

Type Description Link
Fix baseline-error-prone supports java8 palantir/gradle-baseline#1992

4.45.0

Automated release, no documented user facing changes

4.46.0

Automated release, no documented user facing changes

4.47.0

Type Description Link
Fix Gradle plugins don't enforce PublicConstructorForAbstractClass which can break gradle injection palantir/gradle-baseline#2009

4.48.0

Type Description Link
Improvement Disable errorprone in intellij palantir/gradle-baseline#2010

4.49.0

Type Description Link
Improvement Allow projects to override library auto-detection palantir/gradle-baseline#2011

4.50.0

Type Description Link
Improvement Improve coordination between java-versions and idea ipr allowing project iprs to be successfully imported palantir/gradle-baseline#2012

4.51.0

Type Description Link
Fix Idea integration results in correct copyright xml files without duplicate entries palantir/gradle-baseline#2016

4.52.0

Type Description Link
Improvement It's no longer necessary to import an ipr before using gradle integration, code styles are imported correctly out of the box. palantir/gradle-baseline#2015

4.53.0

No documented user facing changes

4.54.0

Type Description Link
Improvement If a subclass of FilterOutputStream implements void write(int), they
should also override void write(byte[], int, int), otherwise the
performance of the stream is likely to be slow.

See https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/io/FilterOutputStream.html#write(byte%5B%5D,int,int)
> Subclasses of FilterOutputStream should provide a more efficient implementation of this method.

Similar in concept to https://errorprone.info/bugpattern/InputStreamSlowMultibyteRead
palantir/gradle-baseline#2024

4.55.0

Type Description Link
Improvement Enable FilterOutputStreamSlowMultibyteWrite at warning level to identify
inefficient FilterOuputStream implementations.

Subclasses of FilterOutputStream should provide a more efficient
implementation of write(byte[], int, int) to avoid slow writes.
palantir/gradle-baseline#2026

4.56.0

Type Description Link
Improvement Add BugCheckerAutoService

Concrete BugChecker implementations should be annotated
@AutoService(BugChecker.class) for auto registration with error-prone.
palantir/gradle-baseline#2028

4.57.0

Type Description Link
Improvement Upon missing jupiter on classpath, suggest putting it on runtime rather than implementation to avoid making checkUnusedDependenciesTest fail in return. palantir/gradle-baseline#2021
Fix Refine FilterOutputStreamSlowMultibyteWrite findings

Avoid warning FilterOutputStreamSlowMultibyteWrite when intermediate
type overrides both single and multibyte write methods.
palantir/gradle-baseline#2031
Improvement Ban AfterburnerModule to reduce JDK-17 risk palantir/gradle-baseline#2032

4.58.0

Type Description Link
Fix DangerousIdentityKey now allows Class to be used as a map or set key. palantir/gradle-baseline#2036

4.59.0

No documented user facing changes

4.60.0

Automated release, no documented user facing changes

4.61.0

Automated release, no documented user facing changes

4.62.0

Automated release, no documented user facing changes

4.63.0

Type Description Link
Improvement Prefer project modules on dependency resolution per default palantir/gradle-baseline#2056

4.64.0

Type Description Link
Improvement Use lazy task initialization for the compileRefaster task for improved performance when it is not needed. palantir/gradle-baseline#2052

4.65.0

Type Description Link
Fix Handle java 17 removal of :com/sun/tools/javac/util/Filter in DangerousIdentityKey palantir/gradle-baseline#2058

4.66.0

Type Description Link
Feature Error Prone can be explicitly enabled using the com.palantir.baseline-error-prone.disable=false Gradle property. palantir/gradle-baseline#2042

4.67.0

Automated release, no documented user facing changes

4.68.0

Type Description Link
Improvement Remove support for running errorprone witth java 8 target compatibility palantir/gradle-baseline#2061
Improvement StrictUnusedVariable no longer flags parameters of default methods. palantir/gradle-baseline#2070

4.69.0

Type Description Link
Improvement enable annotation processing in eclipse by default palantir/gradle-baseline#2076

4.70.0

Automated release, no documented user facing changes

4.71.0

Automated release, no documented user facing changes

4.72.0

Automated release, no documented user facing changes

4.73.0

Type Description Link
Improvement Validate that jqwik tests are run palantir/gradle-baseline#2099

4.74.0

No documented user facing changes

4.75.0

Type Description Link
Improvement Finalize java-versions extension values on read to prevent changes due to interactions from other plugins palantir/gradle-baseline#2107
Improvement baseline-java-versions uses library presets for projects using shadow-jar to prevent resolution/mutation ordering failures palantir/gradle-baseline#2108

4.76.0

Type Description Link
Improvement Prevent instance methods of auth tokens from getting called in logging args palantir/gradle-baseline#2113

4.77.0

Type Description Link
Fix RawTypes no longer flags implicit raw types from lambdas palantir/gradle-baseline#2119

4.78.0

Type Description Link
Improvement Implement IllegalSafeLoggingArgument check palantir/gradle-baseline#2127

4.79.0

Type Description Link
Improvement suggested fixes for IllegalSafeLoggingArgument check palantir/gradle-baseline#2133

4.80.0

Type Description Link
Improvement Compilation supports add-exports/add-opens with toolchains palantir/gradle-baseline#2136

4.81.0

Type Description Link
Improvement Javadoc tasks supporty BaselineModuleJvmArgs palantir/gradle-baseline#2137

4.82.0

Automated release, no documented user facing changes

4.83.0

Type Description Link
Improvement Fix BaselineModuleJvmArgs without toolchains palantir/gradle-baseline#2148

4.84.0

Type Description Link
Improvement Implement Safety flow checks palantir/gradle-baseline#2143

4.85.0

Type Description Link
Improvement Throwable.getMessage is unsafe by default palantir/gradle-baseline#2151

4.86.0

Type Description Link
Improvement Ban java deserialization palantir/gradle-baseline#2152

4.87.0

Type Description Link
Improvement Array assignment merges safety rather than replacing it palantir/gradle-baseline#2154

4.88.0

Type Description Link
Improvement Fix switch expression handling palantir/gradle-baseline#2157

4.89.0

Type Description Link
Improvement Add known safety-passthrough methods palantir/gradle-baseline#2159

4.90.0

Type Description Link
Improvement Validate annotated variable and field assignment safety palantir/gradle-baseline#2160

4.91.0

Type Description Link
Fix Fix SerializationUtils matcher palantir/gradle-baseline#2164

4.92.0

Type Description Link
Fix Avoid nulls in safety analysis palantir/gradle-baseline#2169

4.93.0

Type Description Link
Improvement prevent using logsafe Args with guava Preconditions palantir/gradle-baseline#2139

4.94.0

Type Description Link
Improvement Compilation uses 'opens' values as 'exports' palantir/gradle-baseline#2167

4.95.0

Type Description Link
Improvement Validate that safety var annotations and type annotations agree palantir/gradle-baseline#2161

4.96.0

Type Description Link
Improvement Support safety passthrough on several streamlike methods palantir/gradle-baseline#2174

4.97.0

Type Description Link
Fix Fix errorprone excluded-path regex on Windows palantir/gradle-baseline#2178

4.98.0

Type Description Link
Improvement Upgrade errorprone to 2.12.1 (from 2.11.0) palantir/gradle-baseline#2181, https://github.com/google/error-prone/releases/tag/v2.12.0, https://github.com/google/error-prone/releases/tag/v2.12.1

4.99.0

Type Description Link
Feature prevent exceptions from being passed into Args palantir/gradle-baseline#2140

4.100.0

Type Description Link
Improvement Lambdas/Anon-classes follow captured local variable safety palantir/gradle-baseline#2177

4.101.0

Type Description Link
Improvement Support safety annotations on type-use e.g. Collection<@Safe String> palantir/gradle-baseline#2187

4.102.0

Type Description Link
Fix Fix the com.palantir.baseline-circleci plugin so that compilation failures are once again parsed as XML and can be surfaced at the top of CircleCI builds. palantir/gradle-baseline#2189

4.103.0

Type Description Link
Fix Fix TypeArgumentHandler NPE on wildcard types palantir/gradle-baseline#2190

4.104.0

Type Description Link
Fix Fix index-out-of-bounds analyzing type parameters on raw types palantir/gradle-baseline#2197

4.105.0

Type Description Link
Improvement Automatically fix upstream LongDoubleConversion palantir/gradle-baseline#2199, https://errorprone.info/bugpattern/LongDoubleConversion

4.106.0

Type Description Link
Improvement Implement RID safety passthrough based on the locator component palantir/gradle-baseline#2202

4.107.0

Type Description Link
Improvement Upgrade error-prone to 2.13.1 (from 2.12.1)

Use non-deprecated isSuppressed methods
palantir/gradle-baseline#2203

4.108.0

Type Description Link
Improvement LoggingDoNotLog check ensures credentials aren't logged in any form palantir/gradle-baseline#2205

4.109.0

Type Description Link
Improvement Add ImmutablesReferenceEquality check that checks for comparison of Immutables values using reference equality. palantir/gradle-baseline#2210

4.110.0

Type Description Link
Fix Include mocktio-errorprone after it has picked up new errorprone palantir/gradle-baseline#2215

4.111.0

Type Description Link
Improvement Rename LogsafeArgument to LogsafeThrowableArgument palantir/gradle-baseline#2216

4.112.0

Type Description Link
Improvement SafeLoggingPropagation error-prone check propages log-safety annotations from getters and superclasses/superinterfaces to the type level palantir/gradle-baseline#2218

4.113.0

Type Description Link
Improvement Streamline Throwable safety handling palantir/gradle-baseline#2224

4.114.0

Type Description Link
Improvement Disable intellij's ClassCanBeRecord inspection palantir/gradle-baseline#2225

4.115.0

Type Description Link
Fix SafeLoggingPropagation doesn't attempt to annotate anonymous classes palantir/gradle-baseline#2227

4.116.0

Automated release, no documented user facing changes

4.117.0

Type Description Link
Improvement Propagate additional safety information in the SafeLoggingPropagation check and automated fixes:
1. Method return statements are analyzed to determine safety of unmarked methods
2. Types are annotated based on the safety of their toString method, which is a reasonable heuristic for value types that may be logged.
palantir/gradle-baseline#2230

4.118.0

Type Description Link
Fix Results of boolean logic are considered safe palantir/gradle-baseline#2232

4.119.0

Type Description Link
Feature Add a configuration point for providing your own JDKs to all java requiring tasks. palantir/gradle-baseline#2193

4.120.0

Type Description Link
Fix Fix intellij gradle integration copyright configuration palantir/gradle-baseline#2234

4.121.0

Type Description Link
Improvement Safety propagation ignores utility methods on immutables definitions palantir/gradle-baseline#2237

4.122.0

Type Description Link
Improvement Automatically fix upstream NarrowCalculation palantir/gradle-baseline#2240

4.123.0

Type Description Link
Improvement Fix safety evaluation requiring lhs of an assignment to be safe unnecessarily palantir/gradle-baseline#2242

4.124.0

Type Description Link
Fix VarUsage failures reference a real tree palantir/gradle-baseline#2244

4.125.0

Type Description Link
Improvement Implement safety tracking through StringBuilder/StringBuffer palantir/gradle-baseline#2245

4.126.0

Type Description Link
Improvement Safety propagation takes immutables redaction into account palantir/gradle-baseline#2251

4.127.0

Type Description Link
Improvement Implement class-level type variable safety validation palantir/gradle-baseline#2254

4.128.0

Type Description Link
Improvement Implement method type argument validation palantir/gradle-baseline#2255

4.129.0

Automated release, no documented user facing changes

4.130.0

Type Description Link
Fix Make interactions with gradle java toolchains more lazy, so StackOverflowErrors do not occur palantir/gradle-baseline#2260

4.131.0

Type Description Link
Fix Stream.collect safety no longer incorrectly includes map collectors palantir/gradle-baseline#2264

4.132.0

Type Description Link
Improvement Safety analysis checks superinterfaces (in addition to superclasses) palantir/gradle-baseline#2267

4.133.0

Type Description Link
Fix More lazily acquire JDK storage locations palantir/gradle-baseline#2263

4.134.0

Type Description Link
Fix Fix concurrency issue in LazilyConfiguredMapping palantir/gradle-baseline#2268

4.135.0

Type Description Link
Improvement Safety analysis detects annotations on superclasses and their interfaces palantir/gradle-baseline#2271

4.136.0

Type Description Link
Fix Use LazilyConfiguredMapping that was extracted out to gradle-utils. palantir/gradle-baseline#2276

4.137.0

Type Description Link
Improvement Immutables redactions may be unsafe (previously forced do-not-log) palantir/gradle-baseline#2277

4.138.0

Type Description Link
Fix Removed built in support for eclipse annotation processor configurations - please use gradle-processors instead if using eclipse. palantir/gradle-baseline#2279

4.139.0

Type Description Link
Fix Rerelease due to failed publish palantir/gradle-baseline#2280

4.140.0

Type Description Link
Improvement Update AvoidNewHashMapInt to warn on uses of new HashSet(int). palantir/gradle-baseline#2292

4.141.0

Type Description Link
Improvement Trust type safety on cast results, based on validation that occurred when the type was created. palantir/gradle-baseline#2289

4.142.0

Type Description Link
Fix Fix class hierarchy safe-logging error message agreement palantir/gradle-baseline#2295

4.143.0

Type Description Link
Improvement Avoid configuring many gradle tasks palantir/gradle-baseline#2290

4.144.0

Type Description Link
Improvement Avoid creating and configuring gradle tasks palantir/gradle-baseline#2299

4.145.0

Type Description Link
Improvement The mockito error-prone library is no longer included by default palantir/gradle-baseline#2302

4.146.0

Automated release, no documented user facing changes

4.147.0

Automated release, no documented user facing changes

4.148.0

Type Description Link
Fix Handle safety flow through instanceof pattern matching palantir/gradle-baseline#2331

4.149.0

Type Description Link
Feature Users of the com.palantir.baseline-java-versions plugin can now set javaVersions { distributionTarget = '17_PREVIEW' } to opt-in to Java's --enable-preview flag at compile time. palantir/gradle-baseline#2322

4.150.0

Type Description Link
Fix Fix the BaselineModuleJvmArgs plugin to once again work as intended in multi-project builds palantir/gradle-baseline#2336

4.151.0

Type Description Link
Fix javadoc tasks are now properly configured when --enable-preview is used palantir/gradle-baseline#2338

4.152.0

Type Description Link
Feature Add DefaultLocale check

Related to google/error-prone issues 632

Adds a DefaultLocale check that replaces uses of String.toLowerCase() and String.toUpperCase() with the overloads that take a Locale, using Locale.ROOT.
palantir/gradle-baseline#2343

4.153.0

Type Description Link
Fix Set the java launcher for Checkstyle tasks, too palantir/gradle-baseline#2351

4.154.0

Type Description Link
Improvement The JUnits reports plugin is no longer applied by default. Test reports now use the standard output locations from Gradle conventions. palantir/gradle-baseline#2355

4.155.0

Automated release, no documented user facing changes

4.156.0

Type Description Link
Fix Fix BaselineJavaVersion checkstyle configuration on gradle < 7.5 palantir/gradle-baseline#2360

4.157.0

Type Description Link
Improvement Make task initialization lazier in the junit-reports plugin. palantir/gradle-baseline#2364

4.158.0

Type Description Link
Fix Make the checkUnusedDependencies tasks added by baseline-exact-dependencies compatible with Gradle's configure-on-demand feature. palantir/gradle-baseline#2363

4.159.0

Type Description Link
Improvement Add an errorprone check and typed annotation for Javax -> Jakarta

There is a certain class of very problematic cases whereby if you have
a method such as the following:

<br>myJerseyResource.register(/* this is of type Object */ object);<br>

Then if you supply a resource which includes any javax.ws.rs
annotations on it, then those will not be registered if your Jersey
version is 3.x or later (and you'll only find this out at runtime).

The opposite is also true if you try to supply resources annotated
with jakarta.ws.rs to Jersey 2.x.

To address this, this commit attempts to add an errorprone check
which lets implementors add an annotation @ForbidJavax to methods
which have been knowingly migrated to Jakarta EE9 and cannot
accept legacy javax types.
palantir/gradle-baseline#2366

4.160.0

Type Description Link
Fix Workaround to IDEA-301084 palantir/gradle-baseline#2368

4.161.0

Type Description Link
Fix Reverts a change introduced to baseline-java-version 4.160.0, which was causing failures on multi-project builds. palantir/gradle-baseline#2369

4.162.0

Type Description Link
Feature java versions preview enhancements

+ support setting preview on a project-by-project basis.
+ Fixes #2340
+ fails more elegantly if javaVersions is set on not-the-root.
palantir/gradle-baseline#2376

4.163.0

Type Description Link
Fix Fix interface visibility bug palantir/gradle-baseline#2379

4.164.0

Type Description Link
Improvement The CyclomaticComplexity check is now configured with switchBlockAsSingleDecisionPoint. palantir/gradle-baseline#2383

4.165.0

Type Description Link
Improvement Implement a simple nullaway wrapper plugin com.palantir.baseline-null-away which registers the NullAway check at WARNING. Projects which fail on warnings will require this to pass pre-merge. palantir/gradle-baseline#2382

4.166.0

Automated release, no documented user facing changes

4.167.0

Automated release, no documented user facing changes

4.168.0

Type Description Link
Fix Roll back nullaway+checkerframework for jdk15 support palantir/gradle-baseline#2389

4.169.0

Type Description Link
Improvement Exclude Spark UnusedStubClass from class uniqueness palantir/gradle-baseline#2390

4.170.0

Type Description Link
Fix lazily configure NullAway dependencies to successfully apply NullAway without ordering issues palantir/gradle-baseline#2393

4.171.0

Type Description Link
Fix com.palantir.baseline-null-away no longer enables the CheckOptionalEmptiness checker by default. palantir/gradle-baseline#2396

4.172.0

Automated release, no documented user facing changes

4.173.0

Type Description Link
Fix Nullaway is not enabled in test sources palantir/gradle-baseline#2402

4.174.0

Type Description Link
Improvement Allow projects which don't use jdk-15 to resolve latest nullaway palantir/gradle-baseline#2400

4.175.0

Type Description Link
Fix Fix GitHub issues navigation Idea config palantir/gradle-baseline#2403

4.176.0

Type Description Link
Improvement Error-prone is enabled in idea for uniformity with CLI compilation palantir/gradle-baseline#2405

4.177.0

Type Description Link
Fix baseline-immutables adds required exports to the java compiler for compatibility with jdk-17+ palantir/gradle-baseline#2406

4.178.0

Type Description Link
Fix Refaster compilation uses exports matching error-prone compilation palantir/gradle-baseline#2407

4.179.0

Type Description Link
Improvement Implement ImmutableMapDuplicateKeyStrategy for obvious map construction. By default we suggest replacing build() with the more descriptive buildOrThrow(), however buildKeepingLast() may be the original intent in some cases. palantir/gradle-baseline#2416

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 4 times, most recently from a1e8f2a to 97a70c2 Compare November 30, 2021 17:49
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 3 times, most recently from 85ecbd4 to 82625c9 Compare December 11, 2021 20:33
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 82625c9 to 7c2e067 Compare December 18, 2021 21:50
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 7c2e067 to d287065 Compare December 25, 2021 23:11
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 4 times, most recently from ff5d7b7 to 02eab8f Compare January 8, 2022 01:28
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 4 times, most recently from 4c8e98d to 03899c3 Compare January 17, 2022 15:51
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 3 times, most recently from f672b59 to fbc9e7a Compare January 25, 2022 16:48
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 2 times, most recently from 97b37c1 to 71253a6 Compare February 1, 2022 08:38
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 71253a6 to 2ca14b4 Compare February 7, 2022 21:46
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 2ca14b4 to 228de46 Compare February 15, 2022 03:26
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 4 times, most recently from 8edcb30 to 2ca1e44 Compare February 24, 2022 01:07
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 3 times, most recently from 644cb1a to ec48392 Compare May 16, 2022 22:08
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from ec48392 to 737db30 Compare May 23, 2022 22:25
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 2 times, most recently from 5c9b092 to 4aaae77 Compare June 6, 2022 21:40
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 3 times, most recently from 8f99f03 to 161b585 Compare June 8, 2022 20:33
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 2 times, most recently from 99f4177 to 7c2128b Compare June 15, 2022 18:29
@svc-excavator-bot svc-excavator-bot changed the title Excavator: Upgrades Baseline to the latest version Excavator: Upgrades Baseline to the latest version Jun 22, 2022
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 7c2128b to 4392957 Compare June 22, 2022 19:12
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 3 times, most recently from 86d07cc to 0f7da31 Compare July 6, 2022 00:17
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 0f7da31 to f479132 Compare July 13, 2022 05:26
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 2 times, most recently from 230f361 to 4f0c84c Compare July 26, 2022 11:48
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 3 times, most recently from aabd728 to bb195af Compare August 3, 2022 01:18
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from bb195af to 93ac836 Compare August 8, 2022 14:03
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 93ac836 to 7f3109c Compare September 30, 2022 10:11
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 7f3109c to e555cc5 Compare September 30, 2022 13:53
@bulldozer-bot bulldozer-bot bot merged commit ff36a0f into develop Oct 3, 2022
@bulldozer-bot bulldozer-bot bot deleted the roomba/latest-baseline-oss branch October 3, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants