Fix safety evaluation requiring lhs assignment to be safe unnecessarily #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type parameter passthrough code would evaluate to SAFE rather than UNKNOWN when type parameters were unknown/erased.
Generate changelog in
|
carterkozak
commented
May 1, 2022
| "Test.java", | ||
| "import com.palantir.logsafe.*;", | ||
| "import java.util.*;", | ||
| "class Test<OutputT> {", |
There was a problem hiding this comment.
This test exposed the issue, but only when the (unused) type parameter is present. JCTree.type of the field when <OutputT> is present is java.util.Set and without it, JCTree.type is java.util.Set<java.lang.Throwable>!
I've updated the check to both:
- avoid returning type-info based safety in the case that there's no type info
- check both the symbol type and tree type for safety info
xRuiAlves
approved these changes
May 2, 2022
|
Released 4.123.0 |
This was referenced May 2, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
May 2, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.123.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Fix safety evaluation requiring lhs of an assignment to be safe unnecessarily | palantir/gradle-baseline#2242 | ## 4.124.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | VarUsage failures reference a real tree | palantir/gradle-baseline#2244 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type parameter passthrough code would evaluate to SAFE rather
as opposed to UNKNOWN when type parameters were unknown/erased.
==COMMIT_MSG==
Fix safety evaluation requiring lhs of an assignment to be safe unnecessarily
==COMMIT_MSG==