configure codeStyles for intellij import #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Dec 9, 2021
Comment on lines
-179
to
-182
| // Just add the default configuration nodes on top of whatever nodes already exist | ||
| // We could be better about this, but IDEA will mostly resolve the duplicates here for us | ||
| ideaStyleSettings.value.option.forEach { | ||
| codeScheme.append(it) |
There was a problem hiding this comment.
Turns out Project.xml used to grow indefinitely over time....
fawind
reviewed
Dec 10, 2021
| // We could be better about this, but IDEA will mostly resolve the duplicates here for us | ||
| ideaStyleSettings.value.option.forEach { | ||
| codeScheme.append(it) | ||
| codeScheme.attributes().putIfAbsent("version", 173) |
There was a problem hiding this comment.
Do we need to keep this version updated going forwards?
There was a problem hiding this comment.
I'm not entirely sure, but the property names may not work correctly on other versions
|
Released 4.52.0 |
This was referenced Dec 10, 2021
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Dec 10, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.51.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Idea integration results in correct copyright xml files without duplicate entries | palantir/gradle-baseline#2016 | ## 4.52.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | It's no longer necessary to import an ipr before using gradle integration, code styles are imported correctly out of the box. | palantir/gradle-baseline#2015 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Dec 10, 2021
This was referenced Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based in part upon #1231 (Thanks @dansanduleac!)
Before this PR
Import
.ipr, then migrate to gradle integrationAfter this PR
==COMMIT_MSG==
It's no longer necessary to import an ipr before using gradle integration, code styles are imported correctly out of the box.
==COMMIT_MSG==
Possible downsides?
Maybe I messed up?