-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure codeStyles for intellij import #2015
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -152,6 +152,11 @@ class BaselineIdea extends AbstractBaselinePlugin { | |
|
||
private void addCodeStyleIntellijImport() { | ||
def ideaStyleFile = project.file("${configDir}/idea/intellij-java-palantir-style.xml") | ||
// This runs eagerly, so the file might not exist if we haven't run `baselineUpdateConfig` yet. | ||
// Thus, don't do anything if the file is not there yet. | ||
if (!ideaStyleFile.isFile()) { | ||
return | ||
} | ||
|
||
def ideaStyle = new XmlParser().parse(ideaStyleFile) | ||
.component | ||
|
@@ -176,10 +181,15 @@ class BaselineIdea extends AbstractBaselinePlugin { | |
project.file(".idea/codeStyles/Project.xml"), | ||
{ | ||
def codeScheme = GroovyXmlUtils.matchOrCreateChild(it, "code_scheme", [name: 'Project']) | ||
// Just add the default configuration nodes on top of whatever nodes already exist | ||
// We could be better about this, but IDEA will mostly resolve the duplicates here for us | ||
ideaStyleSettings.value.option.forEach { | ||
codeScheme.append(it) | ||
codeScheme.attributes().putIfAbsent("version", 173) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to keep this version updated going forwards? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not entirely sure, but the property names may not work correctly on other versions |
||
def javaCodeStyleSettings = GroovyXmlUtils.matchOrCreateChild(codeScheme, "JavaCodeStyleSettings") | ||
// Avoid re-adding duplicate options to the project. This allows users to override settings based | ||
// on preference. | ||
ideaStyleSettings.value.option.forEach { ideaStyleSetting -> | ||
def settingName = ideaStyleSetting.attributes().get("name") | ||
if (settingName != null && javaCodeStyleSettings["option"].find { it.attributes().get("name") == settingName } == null) { | ||
javaCodeStyleSettings.append(ideaStyleSetting) | ||
} | ||
} | ||
}, | ||
{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out
Project.xml
used to grow indefinitely over time....