Idea integration results in correct copyright xml files #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had:
```xml
<component name="CopyrightManager">
<copyright>
<option name="notice" value="(c) Copyright ${today.year} Palantir
Technologies Inc. All rights reserved. Licensed under the
Apache License, Version 2.0 (the "License"); you may not
use this file except in compliance with the License. You may obtain
a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0 Unless required by
applicable law or agreed to in writing, software distributed under
the License is distributed on an "AS IS" BASIS, WITHOUT
WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See
the License for the specific language governing permissions
and limitations under the License."/>
<option name="keyword" value="Copyright"/>
<option name="allowReplaceKeyword" value=""/>
<option name="myName" value="001_apache-2.0.txt"/>
<option name="myLocal" value="true"/>
</copyright>
<copyright>
<option name="notice" value="(c) Copyright ${today.year} Palantir
Technologies Inc. All rights reserved. Licensed under the
Apache License, Version 2.0 (the "License"); you may not
use this file except in compliance with the License. You may obtain
a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0 Unless required by
applicable law or agreed to in writing, software distributed under
the License is distributed on an "AS IS" BASIS, WITHOUT
WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See
the License for the specific language governing permissions
and limitations under the License."/>
<option name="keyword" value="Copyright"/>
<option name="allowReplaceKeyword" value=""/>
<option name="myName" value="001_apache-2.0.txt"/>
<option name="myLocal" value="true"/>
</copyright>
<copyright>
<option name="notice" value="(c) Copyright ${today.year} Palantir
Technologies Inc. All rights reserved. Licensed under the
Apache License, Version 2.0 (the "License"); you may not
use this file except in compliance with the License. You may obtain
a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0 Unless required by
applicable law or agreed to in writing, software distributed under
the License is distributed on an "AS IS" BASIS, WITHOUT
WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See
the License for the specific language governing permissions
and limitations under the License."/>
<option name="keyword" value="Copyright"/>
<option name="allowReplaceKeyword" value=""/>
<option name="myName" value="001_apache-2.0.txt"/>
<option name="myLocal" value="true"/>
</copyright>
<copyright>
<option name="notice" value="(c) Copyright ${today.year} Palantir
Technologies Inc. All rights reserved. Licensed under the
Apache License, Version 2.0 (the "License"); you may not
use this file except in compliance with the License. You may obtain
a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0 Unless required by
applicable law or agreed to in writing, software distributed under
the License is distributed on an "AS IS" BASIS, WITHOUT
WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See
the License for the specific language governing permissions
and limitations under the License."/>
<option name="keyword" value="Copyright"/>
<option name="allowReplaceKeyword" value=""/>
<option name="myName" value="001_apache-2.0.txt"/>
<option name="myLocal" value="true"/>
</copyright>
</component>
```
Generate changelog in
|
|
I think you want to change the other addcopyright method as well and always make it do createoruodate. Other impl looks for the node before and adds if it doesn’t exist but doesn’t update. |
|
@robert3005 Ya, the IPR implementation could also be better, though that one isn't executed every time gradle operations run from the IDE but is bounded by the times you run My preference is to punt the ipr piece for a separate PR |
|
👍 |
|
Released 4.51.0 |
This was referenced Dec 10, 2021
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Dec 10, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.51.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Idea integration results in correct copyright xml files without duplicate entries | palantir/gradle-baseline#2016 | ## 4.52.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | It's no longer necessary to import an ipr before using gradle integration, code styles are imported correctly out of the box. | palantir/gradle-baseline#2015 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Dec 10, 2021
This was referenced Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had:
==COMMIT_MSG==
Idea integration results in correct copyright xml files without duplicate entries
==COMMIT_MSG==