Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable annotation processing in eclipse by default #2076

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Conversation

rzpt
Copy link
Contributor

@rzpt rzpt commented Feb 10, 2022

Before this PR

Annotation processing does not work in eclipse by default. It is not a feature in regular gradle, but there is a maintained plugin https://github.com/diffplug/goomph that can enable it.

After this PR

==COMMIT_MSG==
enable annotation processing in eclipse by default
==COMMIT_MSG==

Possible downsides?

None.

@policy-bot policy-bot bot requested a review from tetigi February 10, 2022 01:12
@changelog-app
Copy link

changelog-app bot commented Feb 10, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

enable annotation processing in eclipse by default

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@fawind fawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bulldozer-bot bulldozer-bot bot merged commit e1bccff into develop Feb 10, 2022
@bulldozer-bot bulldozer-bot bot deleted the eclipse-apt branch February 10, 2022 14:02
bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Feb 23, 2022
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.69.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | enable annotation processing in eclipse by default | palantir/gradle-baseline#2076 |


## 4.70.0
_Automated release, no documented user facing changes_


To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants