Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that safety var annotations and type annotations agree #2161

Merged
merged 4 commits into from
Apr 2, 2022

Conversation

carterkozak
Copy link
Contributor

==COMMIT_MSG==
Validate that safety var annotations and type annotations agree
==COMMIT_MSG==

@carterkozak carterkozak requested a review from fawind April 1, 2022 17:45
@changelog-app
Copy link

changelog-app bot commented Apr 1, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Validate that safety var annotations and type annotations agree

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from jkozlowski April 1, 2022 17:45
@carterkozak carterkozak requested review from tpetracca and removed request for jkozlowski April 1, 2022 18:49
@carterkozak carterkozak force-pushed the ckozak/validate_annotation_type_agreement branch from 26fffc8 to 178bee4 Compare April 2, 2022 00:41
Copy link
Contributor

@schlosna schlosna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, had one follow up question/suggestion

…prone/safety/SafetyPropagationTransfer.java

Co-authored-by: David Schlosnagle <davids@palantir.com>
@bulldozer-bot bulldozer-bot bot merged commit 60604dc into develop Apr 2, 2022
@bulldozer-bot bulldozer-bot bot deleted the ckozak/validate_annotation_type_agreement branch April 2, 2022 19:06
@svc-autorelease
Copy link
Collaborator

Released 4.95.0

bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Apr 2, 2022
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.94.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Compilation uses 'opens' values as 'exports' | palantir/gradle-baseline#2167 |


## 4.95.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Validate that safety var annotations and type annotations agree | palantir/gradle-baseline#2161 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants