Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation uses 'opens' values as 'exports' #2167

Merged
merged 3 commits into from
Apr 2, 2022

Conversation

carterkozak
Copy link
Contributor

Opens are ignored at compilation time.

==COMMIT_MSG==
Compilation uses 'opens' values as 'exports'
==COMMIT_MSG==

Opens are ignored at compilation time.
@changelog-app
Copy link

changelog-app bot commented Apr 1, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Compilation uses 'opens' values as 'exports'

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from CRogers April 1, 2022 20:37
@carterkozak
Copy link
Contributor Author

This unblocks jdk-17 testing in #2165

Copy link
Contributor

@schlosna schlosna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment nit suggestion

…gins/BaselineModuleJvmArgs.java

Co-authored-by: David Schlosnagle <davids@palantir.com>
@carterkozak
Copy link
Contributor Author

👍

@bulldozer-bot bulldozer-bot bot merged commit 160ffff into develop Apr 2, 2022
@bulldozer-bot bulldozer-bot bot deleted the ckozak/compilation_uses_opens_as_exports branch April 2, 2022 18:04
@svc-autorelease
Copy link
Collaborator

Released 4.94.0

bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Apr 2, 2022
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.94.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Compilation uses 'opens' values as 'exports' | palantir/gradle-baseline#2167 |


## 4.95.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Validate that safety var annotations and type annotations agree | palantir/gradle-baseline#2161 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants