Fix BaselineModuleJvmArgs without toolchains #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the plugin interacts poorly with `BaselineReleaseCompatibility` because `--release` and internal module exports/opens cannot be used at the same time.
Generate changelog in
|
carterkozak
commented
Mar 30, 2022
| // Gradle appears to normalize args, joining '--add-exports java.management/sun.management=ALL-UNNAMED' | ||
| // with an equals. | ||
| result.standardOutput.contains('--add-exports=java.management/sun.management=ALL-UNNAMED') | ||
| } |
There was a problem hiding this comment.
At the moment this test does not reproduce the problem because we run baseline with a java 11 toolchain.
I verified the fix using #2149 locally, but I didn't include it in this change as it's likely to impact other tests.
There was a problem hiding this comment.
Merged in develop to include running tests on Java 15 now.
fawind
approved these changes
Mar 30, 2022
|
Released 4.83.0 |
This was referenced Mar 30, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Mar 30, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.83.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Fix BaselineModuleJvmArgs without toolchains | palantir/gradle-baseline#2148 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the plugin interacts poorly with
BaselineReleaseCompatibilitybecause--releaseand internalmodule exports/opens cannot be used at the same time.
==COMMIT_MSG==
Fix BaselineModuleJvmArgs without toolchains
==COMMIT_MSG==