Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugins don't enforce PublicConstructorForAbstractClass #2009

Merged

Conversation

carterkozak
Copy link
Contributor

It could break gradle magic injection

==COMMIT_MSG==
Gradle plugins don't enforce PublicConstructorForAbstractClass which can break gradle injection
==COMMIT_MSG==

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
It could break gradle magic injection
@changelog-app
Copy link

changelog-app bot commented Dec 7, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Gradle plugins don't enforce PublicConstructorForAbstractClass which can break gradle injection

Check the box to generate changelog(s)

  • Generate changelog entry

Verified

This commit was signed with the committer’s verified signature.
svc-changelog svc-changelog
Copy link
Contributor

@fawind fawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bulldozer-bot bulldozer-bot bot merged commit 0d5e58d into develop Dec 7, 2021
@bulldozer-bot bulldozer-bot bot deleted the ckozak/gradle_plugin_PublicConstructorForAbstractClass branch December 7, 2021 14:18
@svc-autorelease
Copy link
Collaborator

Released 4.47.0

@xRuiAlves
Copy link
Contributor

I'm late

This was referenced Dec 7, 2021
bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Dec 8, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.47.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | Gradle plugins don't enforce PublicConstructorForAbstractClass which can break gradle injection | palantir/gradle-baseline#2009 |


## 4.48.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Disable errorprone in intellij | palantir/gradle-baseline#2010 |


## 4.49.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Allow projects to override library auto-detection | palantir/gradle-baseline#2011 |


## 4.50.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Improve coordination between java-versions and idea ipr allowing project iprs to be successfully imported | palantir/gradle-baseline#2012 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants