Add FilterOutputStreamSlowMultibyteWrite #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a subclass of FilterOutputStream implements `void write(int)`, they should also override `void write(byte[], int, int)`, otherwise the performance of the stream is likely to be slow. See https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/io/FilterOutputStream.html#write(byte%5B%5D,int,int) > Subclasses of FilterOutputStream should provide a more efficient implementation of this method. Similar in concept to https://errorprone.info/bugpattern/InputStreamSlowMultibyteRead
Generate changelog in
|
carterkozak
reviewed
Jan 5, 2022
...eline-java/src/main/groovy/com/palantir/baseline/extensions/BaselineErrorProneExtension.java
Outdated
Show resolved
Hide resolved
carterkozak
approved these changes
Jan 5, 2022
…ensions/BaselineErrorProneExtension.java Co-authored-by: Carter Kozak <ckozak@ckozak.net>
|
Released 4.54.0 |
This was referenced Jan 5, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jan 5, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.54.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | If a subclass of FilterOutputStream implements `void write(int)`, they<br>should also override `void write(byte[], int, int)`, otherwise the<br>performance of the stream is likely to be slow.<br><br>See https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/io/FilterOutputStream.html#write(byte%5B%5D,int,int)<br>> Subclasses of FilterOutputStream should provide a more efficient implementation of this method.<br><br>Similar in concept to https://errorprone.info/bugpattern/InputStreamSlowMultibyteRead | palantir/gradle-baseline#2024 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jan 5, 2022
This was referenced Jan 7, 2022
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Subtypes of
FilterOutputStreamthat do not implementwrite(byte[], int, int)would be inefficient and fall back to single byte writes.After this PR
==COMMIT_MSG==
If a subclass of FilterOutputStream implements
void write(int), theyshould also override
void write(byte[], int, int), otherwise theperformance of the stream is likely to be slow.
See https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/io/FilterOutputStream.html#write(byte%5B%5D,int,int)
Similar in concept to https://errorprone.info/bugpattern/InputStreamSlowMultibyteRead
==COMMIT_MSG==
An example of this being fixed: palantir/hadoop-crypto#42
Possible downsides?