gradle task configuration avoidance #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
also fix an issue in BaselineJavaVersion
rzpt
commented
Jun 11, 2022
| .register("checkJavaVersions", CheckJavaVersionsTask.class, new Action<CheckJavaVersionsTask>() { | ||
| @Override | ||
| public void execute(CheckJavaVersionsTask task) { | ||
| task.getTargetVersion().set(extension.target()); | ||
| task.getRuntimeVersion().set(extension.runtime()); | ||
| project.getTasks().getByName("check").dependsOn(task); |
There was a problem hiding this comment.
This is a problem because check would only depend on checkJavaVersions if checkJavaVersions was configured.
CRogers
approved these changes
Jun 14, 2022
|
Released 4.144.0 |
This was referenced Jun 14, 2022
This was referenced Jun 14, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jun 15, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.144.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Avoid creating and configuring gradle tasks | palantir/gradle-baseline#2299 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix an issue in BaselineJavaVersion
Before this PR
We are unnecessarily creating and configuring tasks during gradle configuration. See https://docs.gradle.org/current/userguide/task_configuration_avoidance.html for more details.
After this PR
==COMMIT_MSG==
Avoid creating and configuring gradle tasks
==COMMIT_MSG==
Possible downsides?
None.