Prevent instance methods of auth tokens from getting called in logging args #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
added
merge when ready
autorelease
no changelog
and removed
merge when ready
no changelog
labels
|
👍 |
|
Released 4.76.0 |
This was referenced Mar 16, 2022
Merged
This was referenced Mar 16, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Mar 16, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.76.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Prevent instance methods of auth tokens from getting called in logging args | palantir/gradle-baseline#2113 | To enable or disable this check, please contact the maintainers of Excavator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Something like this would not get flagged by the existing error-prone check:
After this PR
Instead of just checking that the type of the safe arg parameter is not an auth token, we can also verify that it is not the invocation of a method of an auth token.
Note that this only catches simple cases and can't handle indirections, e.g.
header.toString()being called elsewhere and passed down to the arg.==COMMIT_MSG==
Prevent instance methods of auth tokens from getting called in logging args
==COMMIT_MSG==