Support safety annotations on type-use e.g. Collection<@Safe String>
#2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
Released 4.101.0 |
This was referenced Apr 11, 2022
Merged
This was referenced Apr 11, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 11, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.101.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Support safety annotations on type-use e.g. `Collection<@safe String>` | palantir/gradle-baseline#2187 | ## 4.102.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix the `com.palantir.baseline-circleci` plugin so that compilation failures are once again parsed as XML and can be surfaced at the top of CircleCI builds. | palantir/gradle-baseline#2189 | ## 4.103.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix TypeArgumentHandler NPE on wildcard types | palantir/gradle-baseline#2190 | To enable or disable this check, please contact the maintainers of Excavator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Support safety annotations on type-use e.g.
Collection<@Safe String>==COMMIT_MSG==
Depends on palantir/safe-logging#699
Possible downsides?
This can get tricky -- I haven't implemented anything yet to fail when a
List<@Unsafe String>is passed to a location that requires@Safe. It may be confusing to have the ability to describe a piece of data as@Unsafe List<String>orList<@Unsafe String>, however the upside this feature provides is the ability to handle more complex types cleanly. Consider a map of userId to logins, both of which are strings:Map<@Safe String, @Unsafe String>could be used such thatmap.get(key)is known to be unsafe, whilemap.keySet().iterator().next()is safe.