Allow annotations on type use (List<@Safe String>)

[carterkozak]

==COMMIT_MSG==
Allow annotations on type use (List<@Safe String>)
==COMMIT_MSG==

See examples of enforcement in palantir/gradle-baseline#2187 Tests in particular: https://github.com/palantir/gradle-baseline/pull/2187/files#diff-9f39cf8d659f98e8e09abd4dff1235eb049a8b030370988a6c77d886d3f48bca

    @Test
    public void testUnsafeTypeParameterProvidesSafety() {
        helper().addSourceLines(
                        "Test.java",
                        "import com.palantir.logsafe.*;",
                        "import java.util.*;",
                        "class Test {",
                        "  void f(List<@Unsafe String> input) {",
                        "    // BUG: Diagnostic contains: Dangerous argument value: arg is 'UNSAFE' "
                                + "but the parameter requires 'SAFE'.",
                        "    fun(input.get(0));",
                        "  }",
                        "  private static void fun(@Safe Object obj) {}",
                        "}")
                .doTest();
    }

and

    @Test
    public void testUnsafeTypeParameterConsumesSafety() {
        helper().addSourceLines(
                        "Test.java",
                        "import com.palantir.logsafe.*;",
                        "import java.util.*;",
                        "class Test {",
                        "  void f(List<@Safe String> collection, @Unsafe String data) {",
                        "    // BUG: Diagnostic contains: Dangerous argument value: arg is 'UNSAFE' "
                                + "but the parameter requires 'SAFE'.",
                        "    collection.add(data);",
                        "  }",
                        "}")
                .doTest();
    }

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Allow annotations on type use (List<@Safe String>)

Check the box to generate changelog(s)

• Generate changelog entry

[fawind]

Was wondering for a while what the difference between List<@Safe String> and @Safe List<String> is. But makes sense for the Map<@Safe String, @Unsafe String> example that you mention in the linked baseline PR!

[svc-autorelease]

Released 1.26.0

[carterkozak]

Was wondering for a while what the difference between List<@safe String> and @safe List is.

In the ideal case, we'd only annotate the generic type parameter for container types, however that may be confusing for devs, so I think it's reasonable to support both.