Fix junit-reports in CircleCI #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
Released 4.102.0 |
This was referenced Apr 11, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 11, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.101.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Support safety annotations on type-use e.g. `Collection<@safe String>` | palantir/gradle-baseline#2187 | ## 4.102.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix the `com.palantir.baseline-circleci` plugin so that compilation failures are once again parsed as XML and can be surfaced at the top of CircleCI builds. | palantir/gradle-baseline#2189 | ## 4.103.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix TypeArgumentHandler NPE on wildcard types | palantir/gradle-baseline#2190 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 11, 2022
pkoenig10
reviewed
Aug 9, 2022
| @@ -40,6 +41,7 @@ public final class BaselineCircleCi implements Plugin<Project> { | |||
| @Override | |||
| public void apply(Project project) { | |||
| project.getPluginManager().apply(JunitReportsRootPlugin.class); | |||
| project.getPluginManager().apply(JunitReportsPlugin.class); | |||
There was a problem hiding this comment.
This shouldn't be necessary. In #1764 we explicitly created the JunitReportsRootPlugin that does this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
There's a thread in #dev-foundry-infra where Alexis flagged that it's a little inconvenient to see what the compile failures are in CircleCI.
I thought we were hoisting this information to the top of the build by parsing the junit xml, but empirically it has not been working on the Apollo codebase.
In fact, I found this refactor from May 2021 (so almost exactly a year ago) which introduced a brand new
JunitReportsRootPluginin addition to the existingJunitReportsPlugin.We used to be applying the
JunitReportsPluginautomatically but this was changed (I assume unintentionally) here:https://github.com/palantir/gradle-baseline/pull/1764/files#diff-1ac4be5b278bc51e4c5bdc114f5bc34d9edbe25c509c2af49cdb6d64a2cd5fe0L42
After this PR
==COMMIT_MSG==
Fix the
com.palantir.baseline-circleciplugin so that compilation failures are once again parsed as XML and can be surfaced at the top of CircleCI builds.==COMMIT_MSG==
Possible downsides?