Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix junit-reports in CircleCI #2189

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Fix junit-reports in CircleCI #2189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b63a460
Fix junit-reports in CircleCI
iamdanfox Apr 11, 2022
d5da79f
Add generated changelog entries
svc-changelog Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/@unreleased/pr-2189.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
type: fix
fix:
description: Fix the `com.palantir.baseline-circleci` plugin so that compilation
failures are once again parsed as XML and can be surfaced at the top of CircleCI
builds.
links:
- https://github.com/palantir/gradle-baseline/pull/2189
2 changes: 2 additions & 0 deletions gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineCircleCi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import com.google.common.base.Preconditions;
import com.google.common.base.Splitter;
import com.palantir.gradle.junit.JunitReportsExtension;
import com.palantir.gradle.junit.JunitReportsPlugin;
import com.palantir.gradle.junit.JunitReportsRootPlugin;
import java.io.File;
import java.io.IOException;
Expand All @@ -40,6 +41,7 @@ public final class BaselineCircleCi implements Plugin<Project> {
@Override
public void apply(Project project) {
project.getPluginManager().apply(JunitReportsRootPlugin.class);
project.getPluginManager().apply(JunitReportsPlugin.class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary. In #1764 we explicitly created the JunitReportsRootPlugin that does this.

gradle-baseline/gradle-junit-reports/src/main/java/com/palantir/gradle/junit/JunitReportsRootPlugin.java

Line 60 in 6452ab1

project.allprojects(proj -> proj.getPluginManager().apply(JunitReportsPlugin.class));


configurePluginsForReports(project);
configurePluginsForArtifacts(project);
Expand Down